Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2634453003: Remove SelectionBehaviorOnFocus argument of Document::updateFocusAppearanceSoon(). (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SelectionBehaviorOnFocus argument of Document::updateFocusAppearanceSoon(). The argument was always SelectionBehaviorOnFocus::Restore. Also, rename it to updateFocusAppearanceLater(). This CL removes one callsite in HTMLInputElement::attachLayoutTree(). It was necessary because WebKit recreated Shadow DOM whenever RenderObject was recreated. [1] [1] https://bugs.webkit.org/show_bug.cgi?id=34620 BUG=679631 Review-Url: https://codereview.chromium.org/2634453003 Cr-Commit-Position: refs/heads/master@{#443846} Committed: https://chromium.googlesource.com/chromium/src/+/32bac3b4c95c52cc6820ea90bf60e24e0c745ff0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yosin@, would you review this please?
3 years, 11 months ago (2017-01-13 09:14:49 UTC) #4
yosin_UTC9
lgtm One nit in CL description: This CL removes one callsite in HTMLInputElement::attachLayoutTree(). It was ...
3 years, 11 months ago (2017-01-16 02:20:12 UTC) #7
tkent
On 2017/01/16 at 02:20:12, yosin wrote: > lgtm > > One nit in CL description: ...
3 years, 11 months ago (2017-01-16 02:22:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634453003/1
3 years, 11 months ago (2017-01-16 02:22:42 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 04:46:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32bac3b4c95c52cc6820ea90bf60...

Powered by Google App Engine
This is Rietveld 408576698