Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2634443002: Don't qualify #include in include/ (Closed)

Created:
3 years, 11 months ago by scottmg
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't qualify #include in include/ Followup to https://codereview.chromium.org/2621983002/ so that v8-version-string.h is includeable with varying include search paths. This seems to match the pattern of other #includes in the include/ directory. R=machenbach@chromium.org BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2634443002 Cr-Commit-Position: refs/heads/master@{#42337} Committed: https://chromium.googlesource.com/v8/v8/+/57a87a52700deffdcb89d19de4d5163c4e6878fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8-version-string.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
scottmg
3 years, 11 months ago (2017-01-12 21:48:43 UTC) #1
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-13 10:40:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634443002/1
3 years, 11 months ago (2017-01-13 16:10:19 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 16:53:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/57a87a52700deffdcb89d19de4d5163c4e6...

Powered by Google App Engine
This is Rietveld 408576698