Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2634413002: Faster Reload: Specify AllowCaching = false for some URLDataSources that need it (Closed)

Created:
3 years, 11 months ago by Marc Treib
Modified:
3 years, 11 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Faster Reload: Specify AllowCaching = false for some URLDataSources that need it BUG=669776 Review-Url: https://codereview.chromium.org/2634413002 Cr-Commit-Position: refs/heads/master@{#446010} Committed: https://chromium.googlesource.com/chromium/src/+/c782ea5b9c5d4e85c75ab8a2d601a088376cc1af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M chrome/browser/search/iframe_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/search/thumbnail_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search/thumbnail_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/fallback_icon_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/fallback_icon_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/large_icon_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/large_icon_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Marc Treib
PTAL! (I'll add owners afterwards)
3 years, 11 months ago (2017-01-17 16:26:11 UTC) #4
Takashi Toyoshima
lgtm
3 years, 11 months ago (2017-01-19 06:33:28 UTC) #7
Marc Treib
+bauerb for owners approval. PTAL!
3 years, 11 months ago (2017-01-19 10:55:42 UTC) #8
Marc Treib
*Actually* +bauerb for owners approval. PTAL!
3 years, 11 months ago (2017-01-25 11:47:06 UTC) #10
Bernhard Bauer
lgtm
3 years, 11 months ago (2017-01-25 12:09:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634413002/1
3 years, 11 months ago (2017-01-25 12:26:55 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 13:25:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c782ea5b9c5d4e85c75ab8a2d601...

Powered by Google App Engine
This is Rietveld 408576698