Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2634393002: [MIPS] Fix Apply builtin always taking the slow path. (Closed)

Created:
3 years, 11 months ago by petermarshall
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[MIPS] Fix Apply builtin always taking the slow path. There were multiple bugs in the apply builtins on mips and mips64 which caused them to always take the slow path by calling into the runtime to create the array. The other bugs went undiscovered because those paths were never taken. Review-Url: https://codereview.chromium.org/2634393002 Cr-Commit-Position: refs/heads/master@{#42424} Committed: https://chromium.googlesource.com/v8/v8/+/5e31df230cfec26e4f374a8b8e0c2c7626cc1d92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M src/builtins/mips/builtins-mips.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
petermarshall
PTAL =]
3 years, 11 months ago (2017-01-17 15:55:34 UTC) #4
Benedikt Meurer
Very nice, thanks for fixing. LGTM!
3 years, 11 months ago (2017-01-17 18:24:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634393002/1
3 years, 11 months ago (2017-01-17 18:58:28 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 19:00:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5e31df230cfec26e4f374a8b8e0c2c7626c...

Powered by Google App Engine
This is Rietveld 408576698