Convert SearchTabHelper to use the new navigation callbacks.

Convert SearchTabHelper to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2634333003
Cr-Commit-Position: refs/heads/master@{#444582}
Committed: https://chromium.googlesource.com/chromium/src/+/8f2edb19b97abef9598d3b602ed3740e78b9230e

[jam, 2017-01-17 23:51:54]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 23:52:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-18 00:02:14]

Description was changed from

==========
Convert SearchTabHelper to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert SearchTabHelper to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-01-18 00:02:14]

jam@chromium.org changed reviewers:
+ treib@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:43:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-01-18 04:52:37]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 04:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 06:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 06:32:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2017-01-18 09:49:32]

search_tab_helper LGTM, but there's a failing test
"ExtensionApiTest.TabsOnUpdated" - is that related?

[jam, 2017-01-18 17:31:14]

On 2017/01/18 09:49:32, Marc Treib wrote:
> search_tab_helper LGTM, but there's a failing test
> "ExtensionApiTest.TabsOnUpdated" - is that related?

Looks like with PlzNavigate turned on, the output in the test needs to have
different expectations. I've added some temporary logic to handle this until
PlzNavigate is turned on, then we can remove it.

[jam, 2017-01-18 17:31:23]

The CQ bit was checked by jam@chromium.org

[jam, 2017-01-18 17:31:23]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2634333003/#ps40001
(title: "fix plznavigate run of ExtensionApiTest.TabsOnUpdated")

[commit-bot: I haz the power, 2017-01-18 17:31:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-18 18:31:27]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-01-18 20:47:50]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 20:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:50:01]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-19 01:06:45]

The CQ bit was checked by jam@chromium.org

[jam, 2017-01-19 01:06:46]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2634333003/#ps60001
(title: "closer to original")

[commit-bot: I haz the power, 2017-01-19 01:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:13:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484788005528840,
"parent_rev": "098f72afae1133c762650b2c841981be9b4afe6e", "commit_rev":
"8f2edb19b97abef9598d3b602ed3740e78b9230e"}

[commit-bot: I haz the power, 2017-01-19 01:14:51]

Description was changed from

==========
Convert SearchTabHelper to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert SearchTabHelper to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2634333003
Cr-Commit-Position: refs/heads/master@{#444582}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f2edb19b97abef9598d3b602ed3...
==========

[commit-bot: I haz the power, 2017-01-19 01:14:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8f2edb19b97abef9598d3b602ed3...