Fix a bug when inputting text after grapheme cluster

Fix a bug when inputting text after grapheme cluster

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for grapheme cluster, the old implementation ignored the text 
before the composition.

BUG=680537
TEST=run_webkit_layout_test --gtest_filter=InputMethodControllerTest.SetCompositionAfterEmoji

Review-Url: https://codereview.chromium.org/2634243002
Cr-Commit-Position: refs/heads/master@{#444287}
Committed: https://chromium.googlesource.com/chromium/src/+/af60cd94fd4b6cab16dd5b48d16111afbc9ba524

[yabinh, 2017-01-17 07:34:52]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 07:34:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2017-01-17 07:44:56]

Description was changed from

==========
Fix a bug when inputting text after multi-code text

In InsertIncrementalTextCommand::doApply(), the old implementation
adjusted the position incorrectly when finding common prefix/suffix.

TEST=InputMethodControllerTest.SetCompositionAfterEmoji

BUG=680537
==========

to

==========
Fix a bug when inputting text after multi-code text

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for mulit-code text, the old implementation ignored the text 
before the composition.

TEST=InputMethodControllerTest.SetCompositionAfterEmoji

BUG=680537
==========

[commit-bot: I haz the power, 2017-01-17 08:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 08:50:04]

Dry run: This issue passed the CQ dry run.

[yabinh, 2017-01-17 08:53:11]

yabinh@chromium.org changed reviewers:
+ yosin@chromium.org

[yabinh, 2017-01-17 08:53:11]

PTAL. Thanks!

[yabinh, 2017-01-17 08:59:25]

Description was changed from

==========
Fix a bug when inputting text after multi-code text

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for mulit-code text, the old implementation ignored the text 
before the composition.

TEST=InputMethodControllerTest.SetCompositionAfterEmoji

BUG=680537
==========

to

==========
Fix a bug when inputting text after multi-code text

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for mulit-code text, the old implementation ignored the text 
before the composition.

BUG=680537
TEST=run_webkit_layout_test
--gtest_filter=InputMethodControllerTest.SetCompositionAfterEmoji
==========

[yosin_UTC9, 2017-01-18 05:36:56]

lgtm

s/multiple code text/graphemecluster/

"multiple code text" isn't appeared elsewhere.

Since |selectionStart| always starts at start of grapheme cluster, so it is
reasonable to start at.

[yabinh, 2017-01-18 05:39:39]

Description was changed from

==========
Fix a bug when inputting text after multi-code text

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for mulit-code text, the old implementation ignored the text 
before the composition.

BUG=680537
TEST=run_webkit_layout_test
--gtest_filter=InputMethodControllerTest.SetCompositionAfterEmoji
==========

to

==========
Fix a bug when inputting text after grapheme cluster

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for grapheme cluster, the old implementation ignored the text 
before the composition.

BUG=680537
TEST=run_webkit_layout_test
--gtest_filter=InputMethodControllerTest.SetCompositionAfterEmoji
==========

[yabinh, 2017-01-18 05:41:19]

On 2017/01/18 05:36:56, Yosi_UTC9 wrote:
> lgtm
> 
> s/multiple code text/graphemecluster/
> 
> "multiple code text" isn't appeared elsewhere.
> 
> Since |selectionStart| always starts at start of grapheme cluster, so it is
> reasonable to start at.

Done. Thanks.

[yabinh, 2017-01-18 05:41:42]

The CQ bit was checked by yabinh@chromium.org

[commit-bot: I haz the power, 2017-01-18 05:41:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 05:46:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484718102451240, "parent_rev":
"5a57f605b11128f4d7ceb23999c40fb84275258e", "commit_rev":
"af60cd94fd4b6cab16dd5b48d16111afbc9ba524"}

[commit-bot: I haz the power, 2017-01-18 05:47:40]

Description was changed from

==========
Fix a bug when inputting text after grapheme cluster

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for grapheme cluster, the old implementation ignored the text 
before the composition.

BUG=680537
TEST=run_webkit_layout_test
--gtest_filter=InputMethodControllerTest.SetCompositionAfterEmoji
==========

to

==========
Fix a bug when inputting text after grapheme cluster

In InsertIncrementalTextCommand::doApply(), there was an error when finding
common prefix/suffix of old composition and new composition. When adjusting
the position for grapheme cluster, the old implementation ignored the text 
before the composition.

BUG=680537
TEST=run_webkit_layout_test
--gtest_filter=InputMethodControllerTest.SetCompositionAfterEmoji

Review-Url: https://codereview.chromium.org/2634243002
Cr-Commit-Position: refs/heads/master@{#444287}
Committed:
https://chromium.googlesource.com/chromium/src/+/af60cd94fd4b6cab16dd5b48d161...
==========

[commit-bot: I haz the power, 2017-01-18 05:47:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af60cd94fd4b6cab16dd5b48d161...