Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2634213003: Compile image loader in v2 syntax. (Closed)

Created:
3 years, 11 months ago by fukino
Modified:
3 years, 11 months ago
Reviewers:
oka
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile image loader in v2 syntax. BUG=636289 TEST=run third_party/closure_compiler/run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2634213003 Cr-Commit-Position: refs/heads/master@{#444291} Committed: https://chromium.googlesource.com/chromium/src/+/1e4d406d50527043c11982d27cb1186a72c0f849

Patch Set 1 #

Patch Set 2 : Fix a unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -444 lines) Patch
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D ui/file_manager/image_loader/compiled_resources.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
M ui/file_manager/image_loader/compiled_resources2.gyp View 1 chunk +68 lines, -28 lines 0 comments Download
M ui/file_manager/image_loader/image_loader.js View 1 chunk +1 line, -230 lines 0 comments Download
M ui/file_manager/image_loader/image_loader_unittest.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/image_loader/image_loader_unittest.js View 1 6 chunks +6 lines, -6 lines 0 comments Download
A + ui/file_manager/image_loader/image_loader_util.js View 9 chunks +17 lines, -140 lines 0 comments Download
M ui/file_manager/image_loader/request.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
fukino
PTAL
3 years, 11 months ago (2017-01-18 02:04:05 UTC) #10
oka
lgtm
3 years, 11 months ago (2017-01-18 05:46:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634213003/20001
3 years, 11 months ago (2017-01-18 05:52:12 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 05:57:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e4d406d50527043c11982d27cb1...

Powered by Google App Engine
This is Rietveld 408576698