Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 26342006: Move renderable config list to GrDrawTargetCaps (Closed)

Created:
7 years, 2 months ago by bsalomon
Modified:
7 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Move renderable config list to GrDrawTargetCaps Committed: http://code.google.com/p/skia/source/detail?r=11756

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : turn off gl spew #

Patch Set 4 : fix renaming #

Total comments: 3

Patch Set 5 : fix size_t/int comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -86 lines) Patch
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 3 chunks +29 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 4 chunks +3 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
No functional change (other than printing of renderable configs with the rest of caps).
7 years, 2 months ago (2013-10-14 14:27:40 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/26342006/diff/7001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/26342006/diff/7001/src/gpu/GrDrawTarget.cpp#newcode1047 src/gpu/GrDrawTarget.cpp:1047: SkASSERT(!fConfigRenderSupport[kUnknown_GrPixelConfig]); Very minor nit: why not start at ...
7 years, 2 months ago (2013-10-14 14:43:51 UTC) #2
bsalomon
https://codereview.chromium.org/26342006/diff/7001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/26342006/diff/7001/src/gpu/GrDrawTarget.cpp#newcode1047 src/gpu/GrDrawTarget.cpp:1047: SkASSERT(!fConfigRenderSupport[kUnknown_GrPixelConfig]); On 2013/10/14 14:43:51, robertphillips wrote: > Very minor ...
7 years, 2 months ago (2013-10-14 14:48:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/26342006/7001
7 years, 2 months ago (2013-10-14 15:10:02 UTC) #4
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildSkiaLib, BuildTests http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=821
7 years, 2 months ago (2013-10-14 15:14:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/26342006/14001
7 years, 2 months ago (2013-10-14 15:26:42 UTC) #6
commit-bot: I haz the power
Change committed as 11756
7 years, 2 months ago (2013-10-14 15:33:50 UTC) #7
robertphillips
7 years, 2 months ago (2013-10-16 12:12:36 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/26342006/diff/7001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/26342006/diff/7001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:1047:
SkASSERT(!fConfigRenderSupport[kUnknown_GrPixelConfig]);
Fair enough

Powered by Google App Engine
This is Rietveld 408576698