Support multi-button press for synthetic mouse events

Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In order to
simulate multi-button press, we keep all the pressed buttons in SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003, which will replace
mouse actions in pointer event tests with pointerActionSequence.

BUG=680330
Review-Url: https://codereview.chromium.org/2634183002
Cr-Commit-Position: refs/heads/master@{#444493}
Committed: https://chromium.googlesource.com/chromium/src/+/988a23455eeee97b2611a4400f6716db1cc5c9c1

[lanwei, 2017-01-16 18:47:34]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 18:47:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-16 18:54:20]

Description was changed from

==========
mouse button


 mouse test

BUG=680330
==========

to

==========
Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In
order to simulate multi-button press,
we keep all the pressed buttons in SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003,
which will replace mouse actions in pointer event tests with
pointerActionSequence.

BUG=680330
==========

[lanwei, 2017-01-16 18:54:20]

lanwei@chromium.org changed reviewers:
+ nzolghadr@chromium.org, tdresser@chromium.org

[lanwei, 2017-01-16 18:54:54]

Description was changed from

==========
Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In
order to simulate multi-button press,
we keep all the pressed buttons in SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003,
which will replace mouse actions in pointer event tests with
pointerActionSequence.

BUG=680330
==========

to

==========
Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In
order to
simulate multi-button press, we keep all the pressed buttons in
SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003, which will
replace mouse actions
in pointer event tests with pointerActionSequence.

BUG=680330
==========

[lanwei, 2017-01-16 18:55:11]

Description was changed from

==========
Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In
order to
simulate multi-button press, we keep all the pressed buttons in
SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003, which will
replace mouse actions
in pointer event tests with pointerActionSequence.

BUG=680330
==========

to

==========
Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In
order to
simulate multi-button press, we keep all the pressed buttons in
SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003, which will
replace
mouse actions in pointer event tests with pointerActionSequence.

BUG=680330
==========

[lanwei, 2017-01-16 18:58:04]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-01-16 18:58:20]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-01-16 18:58:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 19:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 19:53:49]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-16 19:56:37]

I spilt the patch for testing on mouse, could you please take another look,
thanks?

[tdresser, 2017-01-16 20:31:52]

Should this have unit tests?

[lanwei, 2017-01-16 22:44:41]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 22:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 23:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 23:50:59]

Dry run: This issue passed the CQ dry run.

[tdresser, 2017-01-17 13:23:18]

https://codereview.chromium.org/2634183002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
(right):

https://codereview.chromium.org/2634183002/diff/40001/content/browser/rendere...
content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc:64:
blink::WebMouseEvent::Button GetWebMouseEventButton(int button) {
We shouldn't duplicate these.

Let's put them somewhere both the test and synthetic_mouse_driver.cc can use
them.

https://codereview.chromium.org/2634183002/diff/40001/content/browser/rendere...
content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc:235: <<
(int)button_ << ", expected "
static_cast

[lanwei, 2017-01-17 19:02:07]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 19:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-17 19:46:59]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 19:47:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-17 19:49:21]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-01-17 19:49:27]

Patchset #4 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-01-17 19:49:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-17 19:49:52]

Patchset #3 (id:60001) has been deleted

[lanwei, 2017-01-17 19:50:34]

https://codereview.chromium.org/2634183002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
(right):

https://codereview.chromium.org/2634183002/diff/40001/content/browser/rendere...
content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc:64:
blink::WebMouseEvent::Button GetWebMouseEventButton(int button) {
On 2017/01/17 13:23:18, tdresser wrote:
> We shouldn't duplicate these.
> 
> Let's put them somewhere both the test and synthetic_mouse_driver.cc can use
> them.

Done.

https://codereview.chromium.org/2634183002/diff/40001/content/browser/rendere...
content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc:235: <<
(int)button_ << ", expected "
On 2017/01/17 13:23:18, tdresser wrote:
> static_cast

Done.

[tdresser, 2017-01-17 20:03:04]

Let's move the static methods to:
https://cs.chromium.org/chromium/src/ui/events/blink/web_input_event_traits.h...

LGTM

[lanwei, 2017-01-17 20:21:30]

lanwei@chromium.org changed reviewers:
+ dcheng@chromium.org

[commit-bot: I haz the power, 2017-01-17 21:13:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 21:13:25]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-17 22:18:42]

dcheng@ could you please take a look at the content/common/input_messages.h,
thanks you!

[lanwei, 2017-01-17 22:26:51]

On 2017/01/17 20:03:04, tdresser wrote:
> Let's move the static methods to:
>
https://cs.chromium.org/chromium/src/ui/events/blink/web_input_event_traits.h...
> 
> LGTM

Tim, web_input_event_traits.h cannot include
"third_party/WebKit/public/platform/WebMouseEvent.h", is there any other place
we can put these static functions, synthetic_web_input_event_builders.cc?

[dcheng, 2017-01-17 23:42:19]

https://codereview.chromium.org/2634183002/diff/100001/content/common/input/s...
File content/common/input/synthetic_pointer_action_params.h (right):

https://codereview.chromium.org/2634183002/diff/100001/content/common/input/s...
content/common/input/synthetic_pointer_action_params.h:79: DCHECK_GE(button_,
0);
Presumably, left/middle/right. Is it possible to make this an enum so
ParamTraits can do some simple range validation?

[lanwei, 2017-01-18 03:22:03]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 03:22:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-18 03:30:02]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 03:30:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-18 03:35:15]

Patchset #4 (id:120001) has been deleted

[lanwei, 2017-01-18 04:24:43]

https://codereview.chromium.org/2634183002/diff/100001/content/common/input/s...
File content/common/input/synthetic_pointer_action_params.h (right):

https://codereview.chromium.org/2634183002/diff/100001/content/common/input/s...
content/common/input/synthetic_pointer_action_params.h:79: DCHECK_GE(button_,
0);
On 2017/01/17 23:42:19, dcheng wrote:
> Presumably, left/middle/right. Is it possible to make this an enum so
> ParamTraits can do some simple range validation?

Done.

[commit-bot: I haz the power, 2017-01-18 04:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 04:24:56]

Dry run: This issue passed the CQ dry run.

[tdresser, 2017-01-18 13:42:22]

On 2017/01/17 22:26:51, lanwei wrote:
> On 2017/01/17 20:03:04, tdresser wrote:
> > Let's move the static methods to:
> >
>
https://cs.chromium.org/chromium/src/ui/events/blink/web_input_event_traits.h...
> > 
> > LGTM
> 
> Tim, web_input_event_traits.h cannot include
> "third_party/WebKit/public/platform/WebMouseEvent.h", is there any other place
> we can put these static functions, synthetic_web_input_event_builders.cc?

Add WebMouseEvent to DEPS.
https://cs.chromium.org/chromium/src/ui/events/blink/DEPS

[dcheng, 2017-01-18 18:32:50]

ipc lgtm

[lanwei, 2017-01-18 19:12:08]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 19:12:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-18 19:15:54]

lgtm

[commit-bot: I haz the power, 2017-01-18 19:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:18:05]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-01-18 19:53:26]

Patchset #5 (id:160001) has been deleted

[lanwei, 2017-01-18 19:57:34]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 19:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-18 20:02:34]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-01-18 20:02:51]

Patchset #5 (id:180001) has been deleted

[commit-bot: I haz the power, 2017-01-18 20:03:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:34:39]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-18 21:35:13]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2017-01-18 21:35:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, dcheng@chromium.org, nzolghadr@chromium.org
Link to the patchset: https://codereview.chromium.org/2634183002/#ps200001
(title: "button")

[commit-bot: I haz the power, 2017-01-18 21:36:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:42:23]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1484775313951380,
"parent_rev": "6c0a0762e46562f77c65b65a4dca2c6c296ba4d8", "commit_rev":
"988a23455eeee97b2611a4400f6716db1cc5c9c1"}

[commit-bot: I haz the power, 2017-01-18 21:43:01]

Description was changed from

==========
Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In
order to
simulate multi-button press, we keep all the pressed buttons in
SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003, which will
replace
mouse actions in pointer event tests with pointerActionSequence.

BUG=680330
==========

to

==========
Support multi-button press for synthetic mouse events

SyntheticWebMouseEventBuilder::Build now only supports left button press. In
order to
simulate multi-button press, we keep all the pressed buttons in
SyntheticMouseDriver.

This is separated from https://codereview.chromium.org/2621353003, which will
replace
mouse actions in pointer event tests with pointerActionSequence.

BUG=680330

Review-Url: https://codereview.chromium.org/2634183002
Cr-Commit-Position: refs/heads/master@{#444493}
Committed:
https://chromium.googlesource.com/chromium/src/+/988a23455eeee97b2611a4400f67...
==========

[commit-bot: I haz the power, 2017-01-18 21:43:02]

Committed patchset #5 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/988a23455eeee97b2611a4400f67...