Fall back to legacy add to homescreen behavior on non-GMS device or GMS isn't availabe.

Fall back to legacy add to homescreen behavior on non-GMS device or GMS isn't availabe.

In WebApkInstaller, we only checks whether the Google Play install
delegate is aviable before calling Google Play's install API. If it
is a non-GMS device, or user failed to connect to Google Play Service
due to Play service is updating or service is disabled ect., the
install would fail.
In this CL we add an additional check of whether we can use Google
Play Service sucessfully on the device. For all the failure cases,
we will fall back to legacy A2HS even when the play_install flag is on.

BUG=679798
Review-Url: https://codereview.chromium.org/2634173002
Cr-Commit-Position: refs/heads/master@{#444365}
Committed: https://chromium.googlesource.com/chromium/src/+/b3c97c14c8f3918440ec8f6ff5f51d03e2284f7e

[Xi Han, 2017-01-16 18:51:08]

Patchset #1 (id:1) has been deleted

[Xi Han, 2017-01-16 19:19:41]

Description was changed from

==========
Fall back to legacy add to homescreen behavior on non-GMS device.

In WebApkInstaller, we add a check of whether Google Play Service is available
on the device. For non-GMS device, we won't continue the Play install process
even when the play_install flag is on.

BUG=679798
==========

to

==========
Fall back to legacy add to homescreen behavior on non-GMS device or GMS isn't
availabe.

In WebApkInstaller, we only checks whether the Google Play install
delegate is aviable before calling Google Play's install API. If it
is a non-GMS device, or user failed to connect to Google Play Service
due to Play service is updating or service is disabled ect., the
install would fail.
In this CL we add an additional check of whether we can use Google
Play Service sucessfully on the device. For all the failure cases,
we will fall back to legacy A2HS even when the play_install flag is on.

BUG=679798
==========

[Xi Han, 2017-01-16 19:25:16]

Patchset #1 (id:20001) has been deleted

[Xi Han, 2017-01-16 19:25:47]

hanxi@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[Xi Han, 2017-01-16 19:25:47]

Hi Peter, could you please take a look? Thanks!

[pkotwicz, 2017-01-17 02:20:41]

LGTM. Thank you for fixing this bug!

https://codereview.chromium.org/2634173002/diff/40001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer_unittest.cc (right):

https://codereview.chromium.org/2634173002/diff/40001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer_unittest.cc:186: // Whether
Google Play Service can be used and the install delegate are
Nit: are -> is

[Xi Han, 2017-01-17 14:36:06]

hanxi@chromium.org changed reviewers:
+ dominickn@chromium.org

[Xi Han, 2017-01-17 14:36:07]

Hi Dominick, could you please take a look? Thanks!

https://codereview.chromium.org/2634173002/diff/40001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer_unittest.cc (right):

https://codereview.chromium.org/2634173002/diff/40001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer_unittest.cc:186: // Whether
Google Play Service can be used and the install delegate are
On 2017/01/17 02:20:41, pkotwicz wrote:
> Nit: are -> is

Done.

[Xi Han, 2017-01-17 14:36:17]

The CQ bit was checked by hanxi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 14:36:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 15:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 15:15:41]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-01-18 00:07:02]

lgtm % nit

https://codereview.chromium.org/2634173002/diff/60001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer.h (right):

https://codereview.chromium.org/2634173002/diff/60001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer.h:127: // Returns whether Google
Play Service can be used and the install delegate is
nit: "Google Play Services"

[Xi Han, 2017-01-18 14:53:27]

https://codereview.chromium.org/2634173002/diff/60001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer.h (right):

https://codereview.chromium.org/2634173002/diff/60001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer.h:127: // Returns whether Google
Play Service can be used and the install delegate is
On 2017/01/18 00:07:02, dominickn wrote:
> nit: "Google Play Services"

Done.

[Xi Han, 2017-01-18 14:53:31]

The CQ bit was checked by hanxi@chromium.org

[Xi Han, 2017-01-18 14:53:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org, dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2634173002/#ps80001
(title: "Nits.")

[commit-bot: I haz the power, 2017-01-18 14:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 15:30:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484751211047790,
"parent_rev": "d204e97ed557e8e23bacd7bacedf4f2cef5d22d0", "commit_rev":
"b3c97c14c8f3918440ec8f6ff5f51d03e2284f7e"}

[commit-bot: I haz the power, 2017-01-18 15:30:44]

Description was changed from

==========
Fall back to legacy add to homescreen behavior on non-GMS device or GMS isn't
availabe.

In WebApkInstaller, we only checks whether the Google Play install
delegate is aviable before calling Google Play's install API. If it
is a non-GMS device, or user failed to connect to Google Play Service
due to Play service is updating or service is disabled ect., the
install would fail.
In this CL we add an additional check of whether we can use Google
Play Service sucessfully on the device. For all the failure cases,
we will fall back to legacy A2HS even when the play_install flag is on.

BUG=679798
==========

to

==========
Fall back to legacy add to homescreen behavior on non-GMS device or GMS isn't
availabe.

In WebApkInstaller, we only checks whether the Google Play install
delegate is aviable before calling Google Play's install API. If it
is a non-GMS device, or user failed to connect to Google Play Service
due to Play service is updating or service is disabled ect., the
install would fail.
In this CL we add an additional check of whether we can use Google
Play Service sucessfully on the device. For all the failure cases,
we will fall back to legacy A2HS even when the play_install flag is on.

BUG=679798

Review-Url: https://codereview.chromium.org/2634173002
Cr-Commit-Position: refs/heads/master@{#444365}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3c97c14c8f3918440ec8f6ff5f5...
==========

[commit-bot: I haz the power, 2017-01-18 15:30:45]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b3c97c14c8f3918440ec8f6ff5f5...