Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2634153002:
Clean up keyboard_unittests. (Closed)
DescriptionClean up keyboard_unittests.
- Introduce ScopedTouchKeyboardEnabler and
ScopedAccessibilityKeyboardEnabler class for managing flags by using
RAII.
- Add dependency to ui_test_pak in keyboard_unittests.
BUG=681007
TEST=keyboard_unittests passes.
Review-Url: https://codereview.chromium.org/2634153002
Cr-Commit-Position: refs/heads/master@{#444562}
Committed: https://chromium.googlesource.com/chromium/src/+/3ad6fbee118e858145e28d4f5720f695069c956b
Patch Set 1 #Patch Set 2 : Clean up keyboard_unittests. #Patch Set 3 : rebase & update commit comment #
Total comments: 2
Patch Set 4 : address the comment #
Messages
Total messages: 28 (23 generated)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
Add ui_test_pak to dependency of keyboard_unittests.
TEST='ninja -C out/Default keyboard_unittests' and running the test
passes.
BUG=n/a
==========
to
==========
Clean up keyboard_unittests.
- Introduce ScopedTouchKeyboardEnabler and
ScopedAccessibilityKeyboardEnabler class for managing flags by using
RAII.
- Add ui_test_pak to dependency of keyboard_unittests.
BUG=681007
TEST=keyboard_unittests passes.
==========
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yhanada@chromium.org changed reviewers: + bshe@chromium.org
Hi bshe@, PTAL.
Description was changed from ========== Clean up keyboard_unittests. - Introduce ScopedTouchKeyboardEnabler and ScopedAccessibilityKeyboardEnabler class for managing flags by using RAII. - Add ui_test_pak to dependency of keyboard_unittests. BUG=681007 TEST=keyboard_unittests passes. ========== to ========== Clean up keyboard_unittests. - Introduce ScopedTouchKeyboardEnabler and ScopedAccessibilityKeyboardEnabler class for managing flags by using RAII. - Add dependency to ui_test_pak in keyboard_unittests. BUG=681007 TEST=keyboard_unittests passes. ==========
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2634153002/diff/40001/ui/keyboard/keyboard_co... File ui/keyboard/keyboard_controller_unittest.cc (right): https://codereview.chromium.org/2634153002/diff/40001/ui/keyboard/keyboard_co... ui/keyboard/keyboard_controller_unittest.cc:524: gfx::Rect screen_bounds = root_window()->bounds(); ScopedTouchKeyboardEnabler scoped_keyboard_enabler; ?
Thanks! https://codereview.chromium.org/2634153002/diff/40001/ui/keyboard/keyboard_co... File ui/keyboard/keyboard_controller_unittest.cc (right): https://codereview.chromium.org/2634153002/diff/40001/ui/keyboard/keyboard_co... ui/keyboard/keyboard_controller_unittest.cc:524: gfx::Rect screen_bounds = root_window()->bounds(); On 2017/01/18 20:52:33, bshe wrote: > ScopedTouchKeyboardEnabler scoped_keyboard_enabler; ? Done.
The CQ bit was checked by yhanada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org Link to the patchset: https://codereview.chromium.org/2634153002/#ps60001 (title: "address the comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484781369871590,
"parent_rev": "d462fc419f40c24915a6c32cea50ecb3c5273f65", "commit_rev":
"3ad6fbee118e858145e28d4f5720f695069c956b"}
Message was sent while issue was closed.
Description was changed from ========== Clean up keyboard_unittests. - Introduce ScopedTouchKeyboardEnabler and ScopedAccessibilityKeyboardEnabler class for managing flags by using RAII. - Add dependency to ui_test_pak in keyboard_unittests. BUG=681007 TEST=keyboard_unittests passes. ========== to ========== Clean up keyboard_unittests. - Introduce ScopedTouchKeyboardEnabler and ScopedAccessibilityKeyboardEnabler class for managing flags by using RAII. - Add dependency to ui_test_pak in keyboard_unittests. BUG=681007 TEST=keyboard_unittests passes. Review-Url: https://codereview.chromium.org/2634153002 Cr-Commit-Position: refs/heads/master@{#444562} Committed: https://chromium.googlesource.com/chromium/src/+/3ad6fbee118e858145e28d4f5720... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/3ad6fbee118e858145e28d4f5720... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
