Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2634133002: Revert of Update layout after TypingCommand::willAddTypingToOpenCommand (Closed)

Created:
3 years, 11 months ago by chongz
Modified:
3 years, 11 months ago
CC:
blink-reviews, chongz, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update layout after TypingCommand::willAddTypingToOpenCommand (patchset #1 id:1 of https://codereview.chromium.org/2594313002/ ) Reason for revert: Reason for revert: We want to revert all CLs and start over the refactor process, see: https://crbug.com/673789. Original issue's description: > Update layout after TypingCommand::willAddTypingToOpenCommand > > This patch is a preparation for https://crrev.com/2558643003, where > TypingCommand::willAddTypingToOpenCommand is modified to fire 'beforeinput' > event. Since the event handler may make layout dirty and all follow-up > operations require clean layout, this patch adds layout update after > TypingCommand::willAddTypingToOpenCommand finishes. > > BUG=670035 > > Committed: https://crrev.com/52e388599d4d76546635b462a534e08dca4ff104 > Cr-Commit-Position: refs/heads/master@{#440387} TBR=dominicc@chromium.org,xiaochengh@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=670035 Review-Url: https://codereview.chromium.org/2634133002 Cr-Commit-Position: refs/heads/master@{#443931} Committed: https://chromium.googlesource.com/chromium/src/+/945ff69e7e98f750bdbd1d5e33ebc98bd4402ca4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 7 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
chongz
Created Revert of Update layout after TypingCommand::willAddTypingToOpenCommand
3 years, 11 months ago (2017-01-16 16:17:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634133002/1
3 years, 11 months ago (2017-01-16 16:18:12 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 19:23:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/945ff69e7e98f750bdbd1d5e33eb...

Powered by Google App Engine
This is Rietveld 408576698