Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2634093004: Convert InfoBarService to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert InfoBarService to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2634093004 Cr-Commit-Position: refs/heads/master@{#445575} Committed: https://chromium.googlesource.com/chromium/src/+/40b77e55ae0e7aecc86f4f3e1e4072c8a8dd92db

Patch Set 1 #

Patch Set 2 : closer to original #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/infobars/infobar_service.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/infobars/infobar_service.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jam
3 years, 11 months ago (2017-01-18 06:11:41 UTC) #6
Peter Kasting
LGTM
3 years, 11 months ago (2017-01-24 00:15:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634093004/20001
3 years, 11 months ago (2017-01-24 00:20:47 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 01:17:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40b77e55ae0e7aecc86f4f3e1e40...

Powered by Google App Engine
This is Rietveld 408576698