Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2634093002: Revert simplification of memory ordering that is causing TSAN errors. (Closed)

Created:
3 years, 11 months ago by bcwhite
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert simplification of memory ordering that is causing TSAN errors. Also added (unrelated) comment. BUG=681349 Review-Url: https://codereview.chromium.org/2634093002 Cr-Commit-Position: refs/heads/master@{#443901} Committed: https://chromium.googlesource.com/chromium/src/+/43c154f97c004706a96ed0f185d6232b12824c76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M base/metrics/persistent_memory_allocator.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bcwhite
3 years, 11 months ago (2017-01-16 14:22:56 UTC) #5
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-16 15:41:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634093002/1
3 years, 11 months ago (2017-01-16 15:42:11 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 15:46:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43c154f97c004706a96ed0f185d6...

Powered by Google App Engine
This is Rietveld 408576698