Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2634073002: Revert of [win] Create ModuleDatabase and ModuleEventSinkImpl. (Closed)

Created:
3 years, 11 months ago by pkalinnikov
Modified:
3 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [win] Create ModuleDatabase and ModuleEventSinkImpl. (patchset #15 id:280001 of https://codereview.chromium.org/2576843002/ ) Reason for revert: Reverting because Win7 Tests (dbg)(1) builder failed on ModuleDatabaseTest.LoadAddressVectorOperations, which crashed: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56436 Original issue's description: > [win] Create ModuleDatabase and ModuleEventSinkImpl. > > This creates the browser-side components of the ModuleDatabase. A > future CL will hook up ModuleWatchers in each process to a singleton > ModuleDatabase in the browser process. > > BUG=662084 > > Review-Url: https://codereview.chromium.org/2576843002 > Cr-Commit-Position: refs/heads/master@{#443651} > Committed: https://chromium.googlesource.com/chromium/src/+/d97de8e6f3e1beba791dfdd6d7f2dd7160c45331 TBR=pmonette@chromium.org,sky@chromium.org,grt@chromium.org,wfh@chromium.org,chrisha@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=662084 Review-Url: https://codereview.chromium.org/2634073002 Cr-Commit-Position: refs/heads/master@{#443889} Committed: https://chromium.googlesource.com/chromium/src/+/7f422465c437cb1da27bf39ac74d0d7d3067a270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1570 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/conflicts/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/conflicts/module_database_win.h View 1 chunk +0 lines, -243 lines 0 comments Download
D chrome/browser/conflicts/module_database_win.cc View 1 chunk +0 lines, -349 lines 0 comments Download
D chrome/browser/conflicts/module_database_win_unittest.cc View 1 chunk +0 lines, -529 lines 0 comments Download
D chrome/browser/conflicts/module_event_sink_impl_win.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/conflicts/module_event_sink_impl_win.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/common/conflicts/module_database_win.mojom View 1 chunk +14 lines, -0 lines 0 comments Download
D chrome/common/conflicts/module_event_sink_win.mojom View 1 chunk +0 lines, -23 lines 0 comments Download
A chrome/common/conflicts/module_event_win.mojom View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/common/conflicts/module_watcher_win.h View 4 chunks +6 lines, -29 lines 0 comments Download
M chrome/common/conflicts/module_watcher_win.cc View 5 chunks +21 lines, -16 lines 0 comments Download
M chrome/common/conflicts/module_watcher_win_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pkalinnikov
Created Revert of [win] Create ModuleDatabase and ModuleEventSinkImpl.
3 years, 11 months ago (2017-01-16 13:29:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634073002/1
3 years, 11 months ago (2017-01-16 13:29:25 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 14:25:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f422465c437cb1da27bf39ac74d...

Powered by Google App Engine
This is Rietveld 408576698