Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2634033003: [heap] Fix live object iterator to skip grey filler objects. (Closed)

Created:
3 years, 11 months ago by Hannes Payer (out of office)
Modified:
3 years, 11 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix live object iterator to skip grey filler objects. BUG=v8:5829 patch from issue 2634493004 at patchset 20001 (http://crrev.com/2634493004#ps20001) Review-Url: https://codereview.chromium.org/2634033003 Cr-Commit-Position: refs/heads/master@{#42383} Committed: https://chromium.googlesource.com/v8/v8/+/38088853de4c88acfae548d249de29992a993f0b

Patch Set 1 #

Patch Set 2 : external #

Patch Set 3 : add header #

Patch Set 4 : stuff #

Patch Set 5 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 1 2 3 4 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Lippautz
lgtm
3 years, 11 months ago (2017-01-16 17:18:12 UTC) #7
Michael Lippautz
lgtm lgtm
3 years, 11 months ago (2017-01-16 17:18:12 UTC) #8
Michael Lippautz
lgtm lgtm lgtm
3 years, 11 months ago (2017-01-16 17:18:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634033003/80001
3 years, 11 months ago (2017-01-16 17:19:24 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 17:21:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/38088853de4c88acfae548d249de29992a9...

Powered by Google App Engine
This is Rietveld 408576698