Web Animations: Support animation of flood-opacity

Web Animations: Support animation of flood-opacity

Note that the existing implementation fails to clamp to the range 0-1.

BUG=257591
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159643

[dstockwell, 2013-10-08 06:21:25]

https://codereview.chromium.org/26340006/diff/1/LayoutTests/animations/interp...
File LayoutTests/animations/interpolation/flood-opacity-interpolation.html
(right):

https://codereview.chromium.org/26340006/diff/1/LayoutTests/animations/interp...
LayoutTests/animations/interpolation/flood-opacity-interpolation.html:14:
<template id="target-template">TT</template>
Is the effect actually visible? I thought flood-opacity only applied to SVG?

[dstockwell, 2013-10-08 07:23:43]

https://codereview.chromium.org/26340006/diff/1/LayoutTests/animations/interp...
File LayoutTests/animations/interpolation/flood-opacity-interpolation.html
(right):

https://codereview.chromium.org/26340006/diff/1/LayoutTests/animations/interp...
LayoutTests/animations/interpolation/flood-opacity-interpolation.html:14:
<template id="target-template">TT</template>
On 2013/10/08 06:21:25, dstockwell wrote:
> Is the effect actually visible? I thought flood-opacity only applied to SVG?

What I mean is can you see the effects of the animation if you open this test in
the browser or content_shell?

I expect you'll need to create some SVG and animate the property on an feFlood
element, like in svg-stop-opacity-interpolation.html where it animates the
opacity of a gradient stop.

[Eric Willigers, 2013-10-11 07:11:10]

> > Is the effect actually visible? I thought flood-opacity only applied to SVG?
> 
> What I mean is can you see the effects of the animation if you open this test
in
> the browser or content_shell?
> 
> I expect you'll need to create some SVG and animate the property on an feFlood
> element, like in svg-stop-opacity-interpolation.html where it animates the
> opacity of a gradient stop.

I have uploaded a new layout test based on svg-stop-opacity-interpolation.html,
but no, I currently can't see the effect.

[dstockwell, 2013-10-13 22:12:19]

On 2013/10/11 07:11:10, Eric Willigers wrote:
> > > Is the effect actually visible? I thought flood-opacity only applied to
SVG?
> > 
> > What I mean is can you see the effects of the animation if you open this
test
> in
> > the browser or content_shell?
> > 
> > I expect you'll need to create some SVG and animate the property on an
feFlood
> > element, like in svg-stop-opacity-interpolation.html where it animates the
> > opacity of a gradient stop.
> 
> I have uploaded a new layout test based on
svg-stop-opacity-interpolation.html,
> but no, I currently can't see the effect.

OK, lgtm. But please file a bug that animation of flood-opacity appears to be
broken. You might be able to do some archaeology to discover whether it was
tested when first added.

[Steve Block, 2013-10-13 23:00:14]

Eric, do you mean that flood-opacity isn't being animated, or that it doesn't
work at all (even outside of an animation)?

I think you're using the <use> element incorrectly. I just hacked a test case
based on the flood-color test and it seems to work OK.

[Eric Willigers, 2013-10-13 23:39:31]

On 2013/10/13 23:00:14, Steve Block wrote:
> Eric, do you mean that flood-opacity isn't being animated, or that it doesn't
> work at all (even outside of an animation)?
> 
> I think you're using the <use> element incorrectly. I just hacked a test case
> based on the flood-color test and it seems to work OK.

flood-opacity wasn't being animated.

I have updated the test case, using the floor color test and specifying
class="target" on the feFlood element, and now the opacity animation is visible.

[commit-bot: I haz the power, 2013-10-13 23:39:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/26340006/17001

[commit-bot: I haz the power, 2013-10-14 23:33:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/26340006/17001

[commit-bot: I haz the power, 2013-10-14 23:34:05]

Failed to apply patch for
Source/core/animation/css/CSSAnimatableValueFactory.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/animation/css/CSSAnimatableValueFactory.cpp
  Hunk #1 FAILED at 221.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/animation/css/CSSAnimatableValueFactory.cpp.rej

Patch:       Source/core/animation/css/CSSAnimatableValueFactory.cpp
Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp
diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp
b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
index
cb9dd3185dde1655cc108fa19d45202433357410..ac457fb3cbf846f902e02f02fcf594f995565b88
100644
--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp
+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
@@ -221,6 +221,8 @@ PassRefPtr<AnimatableValue>
CSSAnimatableValueFactory::create(CSSPropertyID prop
         return createFromLength(style->flexBasis(), style);
     case CSSPropertyFloodColor:
         return createFromColor(property, style);
+    case CSSPropertyFloodOpacity:
+        return createFromDouble(style->floodOpacity());
     case CSSPropertyHeight:
         return createFromLength(style->height(), style);
     case CSSPropertyKerning:

[commit-bot: I haz the power, 2013-10-15 00:00:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/26340006/25001

[commit-bot: I haz the power, 2013-10-15 05:17:04]

Change committed as 159643