Directly use TestImporter in DepsUpdater instead of invoking script.

Directly use TestImporter in DepsUpdater instead of invoking script.

Earlier, when importing W3C tests was in a more experimental phase,
import-w3c-tests was useful as a separate script because it offered
more flexibility in how and what was imported.

Now, however, it's easier to update web-platform-tests or csswg-test,
or import new w3c tests, by editing W3CImportExpectations if necessary
and then running update-w3c-deps.

We'd like to rename update-w3c-deps to make the name clearer, but this
is impeded by confusingly also having a script called import-w3c-tests.

BUG=681406
Review-Url: https://codereview.chromium.org/2633933002
Cr-Commit-Position: refs/heads/master@{#444565}
Committed: https://chromium.googlesource.com/chromium/src/+/57fa7c2cd73975510b7018f8470a67bad5f2e544

[qyearsley, 2017-01-15 23:30:26]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-01-18 00:23:39]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:24:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 02:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 02:26:57]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2017-01-18 20:43:42]

lgtm with nits

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:113: for name in
dirs_to_skip:
It looks like these changes are also included in another CL - I'm assuming this
CL depends on the other one.

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
(right):

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:46:
'/mock-checkout/third_party/WebKit/LayoutTests/imported/README.txt': '',
Should this be `external` now?

[qyearsley, 2017-01-18 23:10:58]

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:113: for name in
dirs_to_skip:
On 2017/01/18 at 20:43:42, jeffcarp wrote:
> It looks like these changes are also included in another CL - I'm assuming
this CL depends on the other one.

Right :-)

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
(right):

https://codereview.chromium.org/2633933002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:46:
'/mock-checkout/third_party/WebKit/LayoutTests/imported/README.txt': '',
On 2017/01/18 at 20:43:42, jeffcarp wrote:
> Should this be `external` now?

Yep! Now changed.

[qyearsley, 2017-01-18 23:11:05]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:11:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-01-19 00:02:42]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2017-01-19 00:02:44]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-01-19 00:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2633933002/#ps60001
(title: "imported -> external")

[commit-bot: I haz the power, 2017-01-19 00:03:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:30:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484784164017120,
"parent_rev": "a5e49a2b2acf7ef4a79030c06589dde1e2ca3684", "commit_rev":
"57fa7c2cd73975510b7018f8470a67bad5f2e544"}

[commit-bot: I haz the power, 2017-01-19 00:31:09]

Description was changed from

==========
Directly use TestImporter in DepsUpdater instead of invoking script.

Earlier, when importing W3C tests was in a more experimental phase,
import-w3c-tests was useful as a separate script because it offered
more flexibility in how and what was imported.

Now, however, it's easier to update web-platform-tests or csswg-test,
or import new w3c tests, by editing W3CImportExpectations if necessary
and then running update-w3c-deps.

We'd like to rename update-w3c-deps to make the name clearer, but this
is impeded by confusingly also having a script called import-w3c-tests.

BUG=681406
==========

to

==========
Directly use TestImporter in DepsUpdater instead of invoking script.

Earlier, when importing W3C tests was in a more experimental phase,
import-w3c-tests was useful as a separate script because it offered
more flexibility in how and what was imported.

Now, however, it's easier to update web-platform-tests or csswg-test,
or import new w3c tests, by editing W3CImportExpectations if necessary
and then running update-w3c-deps.

We'd like to rename update-w3c-deps to make the name clearer, but this
is impeded by confusingly also having a script called import-w3c-tests.

BUG=681406

Review-Url: https://codereview.chromium.org/2633933002
Cr-Commit-Position: refs/heads/master@{#444565}
Committed:
https://chromium.googlesource.com/chromium/src/+/57fa7c2cd73975510b7018f8470a...
==========

[commit-bot: I haz the power, 2017-01-19 00:31:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/57fa7c2cd73975510b7018f8470a...