Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 2633743002: Add GetIsPinnedToTaskbarState() (Closed)

Created:
3 years, 11 months ago by tmartino
Modified:
3 years, 11 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Add GetIsPinnedToTaskbarState() Adds the more general function to get the pinned state and refactor the 2 usages of ShellHandler. BUG=667335 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2512553007 Cr-Commit-Position: refs/heads/master@{#434254} (cherry picked from commit a9831524bf640f9a3eb7842e83fe6c4d3d13652e) Review-Url: https://codereview.chromium.org/2633743002 Cr-Commit-Position: refs/branch-heads/2924@{#763} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/5e0e4bf593146a779fa9a553833d41a8a065096e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -75 lines) Patch
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 3 chunks +33 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_win.h View 1 chunk +10 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 3 chunks +59 lines, -43 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_handler.h View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_handler.cc View 3 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Patrick Monette
lgtm
3 years, 11 months ago (2017-01-13 20:54:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633743002/1
3 years, 11 months ago (2017-01-13 21:02:30 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago (2017-01-13 21:02:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633743002/1
3 years, 11 months ago (2017-01-13 21:03:47 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 21:07:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e0e4bf593146a779fa9a553833d...

Powered by Google App Engine
This is Rietveld 408576698