Add OOPIF-specific test for setting TOUCH_ACTION in PointerEvents.

Add OOPIF-specific test for setting TOUCH_ACTION in PointerEvents.

This CL adds another test for the changes made in
https://codereview.chromium.org/2626133002/.

Specifically, it modifies an existing OOPIF test for touch events sent
to OOPIF subframes, making sure that the target sub-frame's
InputRouterImpl receives the proper TouchAction information from the
renderer.

BUG=680158
Review-Url: https://codereview.chromium.org/2633723002
Cr-Commit-Position: refs/heads/master@{#443692}
Committed: https://chromium.googlesource.com/chromium/src/+/af8f03fcb37a1bb4bf1935c060880d82297350e7

[wjmaclean, 2017-01-13 19:14:15]

Description was changed from

==========
Add OOPIF-specific test for setting TOUCH_ACTION in PointerEvents.

This CL adds another test for the changes made in
https://codereview.chromium.org/2626133002/.

Specifically, it modifies an existing OOPIF test for touch events sent
to OOPIF subframes, making sure that the target sub-frame's
InputRouterImpl receives the proper TouchAction information from the
renderer.

BUG=680158
==========

to

==========
Add OOPIF-specific test for setting TOUCH_ACTION in PointerEvents.

This CL adds another test for the changes made in
https://codereview.chromium.org/2626133002/.

Specifically, it modifies an existing OOPIF test for touch events sent
to OOPIF subframes, making sure that the target sub-frame's
InputRouterImpl receives the proper TouchAction information from the
renderer.

BUG=680158
==========

[wjmaclean, 2017-01-13 19:14:15]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org

[wjmaclean, 2017-01-13 19:14:26]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 19:15:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2017-01-13 19:17:03]

creis@ - please take a look? (small CL)

[wjmaclean, 2017-01-13 20:32:30]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 20:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-01-13 21:37:16]

[+site-isolation-reviews for OOPIF CL]

Thanks for the extra test!  LGTM with nits.

https://codereview.chromium.org/2633723002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/input_router_impl.h (right):

https://codereview.chromium.org/2633723002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/input_router_impl.h:204: TouchAction
allowed_touch_action() {
This isn't needed in production code, right?  Maybe we should name it
allowed_touch_action_for_testing(), or just omit it entirely and access
touch_action_filter_ directly in the test.

https://codereview.chromium.org/2633723002/diff/20001/content/browser/site_pe...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2633723002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:5357: #if defined(USE_AURA)
Just checking-- are you ok with your new test being Aura-only?

https://codereview.chromium.org/2633723002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:5386:
EXPECT_NE(TOUCH_ACTION_AUTO, TOUCH_ACTION_NONE);
nit: Add blank line after.

[commit-bot: I haz the power, 2017-01-13 21:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:46:07]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2017-01-13 21:59:23]

https://codereview.chromium.org/2633723002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/input_router_impl.h (right):

https://codereview.chromium.org/2633723002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/input_router_impl.h:204: TouchAction
allowed_touch_action() {
On 2017/01/13 21:37:17, Charlie Reis wrote:
> This isn't needed in production code, right?  Maybe we should name it
> allowed_touch_action_for_testing(), or just omit it entirely and access
> touch_action_filter_ directly in the test.

Done.

https://codereview.chromium.org/2633723002/diff/20001/content/browser/site_pe...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2633723002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:5357: #if defined(USE_AURA)
On 2017/01/13 21:37:17, Charlie Reis wrote:
> Just checking-- are you ok with your new test being Aura-only?

I think so ... the existing touch-test is Aura only, and RenderWidgetHostViewMac
doesn't (so far as I'm aware) provide support for touchscreen touch events. This
test should presumably run Linux/CrOS and Windows, just leaving Android. It
would be nice to add that later, but for now I'm going for the low-hanging
fruit.

https://codereview.chromium.org/2633723002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:5386:
EXPECT_NE(TOUCH_ACTION_AUTO, TOUCH_ACTION_NONE);
On 2017/01/13 21:37:17, Charlie Reis wrote:
> nit: Add blank line after.

Done.

[wjmaclean, 2017-01-13 21:59:39]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2017-01-13 22:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 22:06:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484344779442950,
"parent_rev": "96f33ef6f7c21303a68dc52c3e27a925fb200ce5", "commit_rev":
"af8f03fcb37a1bb4bf1935c060880d82297350e7"}

[commit-bot: I haz the power, 2017-01-13 22:07:31]

Description was changed from

==========
Add OOPIF-specific test for setting TOUCH_ACTION in PointerEvents.

This CL adds another test for the changes made in
https://codereview.chromium.org/2626133002/.

Specifically, it modifies an existing OOPIF test for touch events sent
to OOPIF subframes, making sure that the target sub-frame's
InputRouterImpl receives the proper TouchAction information from the
renderer.

BUG=680158
==========

to

==========
Add OOPIF-specific test for setting TOUCH_ACTION in PointerEvents.

This CL adds another test for the changes made in
https://codereview.chromium.org/2626133002/.

Specifically, it modifies an existing OOPIF test for touch events sent
to OOPIF subframes, making sure that the target sub-frame's
InputRouterImpl receives the proper TouchAction information from the
renderer.

BUG=680158

Review-Url: https://codereview.chromium.org/2633723002
Cr-Commit-Position: refs/heads/master@{#443692}
Committed:
https://chromium.googlesource.com/chromium/src/+/af8f03fcb37a1bb4bf1935c06088...
==========

[commit-bot: I haz the power, 2017-01-13 22:07:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/af8f03fcb37a1bb4bf1935c06088...