Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_unittest.cc

Issue 2633663003: Implements strict secure cookies as the default behavior in //net (Closed)
Patch Set: Rebase on ToT Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/net/chrome_network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/cookies/cookies_unittest.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_unittest.cc b/chrome/browser/extensions/api/cookies/cookies_unittest.cc
index 724b2fe94c81e706c0f4e148641621c2685e7baf..8eab26262047f7f0dbd5f453c22311ab078152dc 100644
--- a/chrome/browser/extensions/api/cookies/cookies_unittest.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_unittest.cc
@@ -85,11 +85,10 @@ TEST_F(ExtensionCookiesTest, StoreIdProfileConversion) {
TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
std::unique_ptr<net::CanonicalCookie> canonical_cookie1(
- net::CanonicalCookie::Create(GURL("http://www.example.com"), "ABC", "DEF",
- std::string(), "/", base::Time(),
- base::Time(), false, false,
- net::CookieSameSite::DEFAULT_MODE, false,
- net::COOKIE_PRIORITY_DEFAULT));
+ net::CanonicalCookie::Create(
+ GURL("http://www.example.com"), "ABC", "DEF", std::string(), "/",
+ base::Time(), base::Time(), false, false,
+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, canonical_cookie1.get());
Cookie cookie1 =
cookies_helpers::CreateCookie(*canonical_cookie1, "some cookie store");
@@ -106,11 +105,10 @@ TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
EXPECT_EQ("some cookie store", cookie1.store_id);
std::unique_ptr<net::CanonicalCookie> canonical_cookie2(
- net::CanonicalCookie::Create(GURL("http://example.com"), "ABC", "DEF",
- ".example.com", "/", base::Time(),
- base::Time::FromDoubleT(10000), false, false,
- net::CookieSameSite::STRICT_MODE, false,
- net::COOKIE_PRIORITY_DEFAULT));
+ net::CanonicalCookie::Create(
+ GURL("http://example.com"), "ABC", "DEF", ".example.com", "/",
+ base::Time(), base::Time::FromDoubleT(10000), false, false,
+ net::CookieSameSite::STRICT_MODE, net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, canonical_cookie2.get());
Cookie cookie2 =
cookies_helpers::CreateCookie(*canonical_cookie2, "some cookie store");
@@ -133,15 +131,15 @@ TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) {
std::unique_ptr<net::CanonicalCookie> cookie1(net::CanonicalCookie::Create(
GURL("http://example.com"), "ABC", "DEF", "example.com", "/",
base::Time(), base::Time(), false, false,
- net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT));
+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, cookie1.get());
EXPECT_EQ("http://example.com/",
cookies_helpers::GetURLFromCanonicalCookie(*cookie1).spec());
std::unique_ptr<net::CanonicalCookie> cookie2(net::CanonicalCookie::Create(
- GURL("http://helloworld.com"), "ABC", "DEF", ".helloworld.com", "/",
+ GURL("https://helloworld.com"), "ABC", "DEF", ".helloworld.com", "/",
base::Time(), base::Time(), true, false,
- net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT));
+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, cookie2.get());
EXPECT_EQ("https://helloworld.com/",
cookies_helpers::GetURLFromCanonicalCookie(*cookie2).spec());
@@ -179,8 +177,7 @@ TEST_F(ExtensionCookiesTest, DomainMatching) {
std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
GURL(tests[i].url), std::string(), std::string(), tests[i].domain,
std::string(), base::Time(), base::Time(), false, false,
- net::CookieSameSite::DEFAULT_MODE, false,
- net::COOKIE_PRIORITY_DEFAULT));
+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, cookie.get());
EXPECT_EQ(tests[i].matches, filter.MatchesCookie(*cookie));
}
« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/net/chrome_network_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698