Implements strict secure cookies as the default behavior in //net

chrome/browser/extensions/api/cookies/cookies_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests common functionality used by the Chrome Extensions Cookies API
 // implementation.
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include <stddef.h>
@@ skipping 67 matching lines @@
   EXPECT_EQ(profile->GetOffTheRecordProfile(),
             cookies_helpers::ChooseProfileFromStoreId(
                 "1", profile->GetOffTheRecordProfile(), true));
   EXPECT_EQ(profile->GetOffTheRecordProfile(),
             cookies_helpers::ChooseProfileFromStoreId(
                 "1", profile->GetOffTheRecordProfile(), false));
 }
 
 TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
   std::unique_ptr<net::CanonicalCookie> canonical_cookie1(
-      net::CanonicalCookie::Create(GURL("http://www.example.com"), "ABC", "DEF",
-                                   std::string(), "/", base::Time(),
-                                   base::Time(), false, false,
-                                   net::CookieSameSite::DEFAULT_MODE, false,
-                                   net::COOKIE_PRIORITY_DEFAULT));
+      net::CanonicalCookie::Create(
+          GURL("http://www.example.com"), "ABC", "DEF", std::string(), "/",
+          base::Time(), base::Time(), false, false,
+          net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
   ASSERT_NE(nullptr, canonical_cookie1.get());
   Cookie cookie1 =
       cookies_helpers::CreateCookie(*canonical_cookie1, "some cookie store");
   EXPECT_EQ("ABC", cookie1.name);
   EXPECT_EQ("DEF", cookie1.value);
   EXPECT_EQ("www.example.com", cookie1.domain);
   EXPECT_TRUE(cookie1.host_only);
   EXPECT_EQ("/", cookie1.path);
   EXPECT_FALSE(cookie1.secure);
   EXPECT_FALSE(cookie1.http_only);
   EXPECT_EQ(api::cookies::SAME_SITE_STATUS_NO_RESTRICTION, cookie1.same_site);
   EXPECT_TRUE(cookie1.session);
   EXPECT_FALSE(cookie1.expiration_date.get());
   EXPECT_EQ("some cookie store", cookie1.store_id);
 
   std::unique_ptr<net::CanonicalCookie> canonical_cookie2(
-      net::CanonicalCookie::Create(GURL("http://example.com"), "ABC", "DEF",
-                                   ".example.com", "/", base::Time(),
-                                   base::Time::FromDoubleT(10000), false, false,
-                                   net::CookieSameSite::STRICT_MODE, false,
-                                   net::COOKIE_PRIORITY_DEFAULT));
+      net::CanonicalCookie::Create(
+          GURL("http://example.com"), "ABC", "DEF", ".example.com", "/",
+          base::Time(), base::Time::FromDoubleT(10000), false, false,
+          net::CookieSameSite::STRICT_MODE, net::COOKIE_PRIORITY_DEFAULT));
   ASSERT_NE(nullptr, canonical_cookie2.get());
   Cookie cookie2 =
       cookies_helpers::CreateCookie(*canonical_cookie2, "some cookie store");
   EXPECT_FALSE(cookie2.host_only);
   EXPECT_FALSE(cookie2.session);
   EXPECT_EQ(api::cookies::SAME_SITE_STATUS_STRICT, cookie2.same_site);
   ASSERT_TRUE(cookie2.expiration_date.get());
   EXPECT_EQ(10000, *cookie2.expiration_date);
 
   TestingProfile profile;
   base::ListValue* tab_ids_list = new base::ListValue();
   std::vector<int> tab_ids;
   CookieStore cookie_store =
       cookies_helpers::CreateCookieStore(&profile, tab_ids_list);
   EXPECT_EQ("0", cookie_store.id);
   EXPECT_EQ(tab_ids, cookie_store.tab_ids);
 }
 
 TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) {
   std::unique_ptr<net::CanonicalCookie> cookie1(net::CanonicalCookie::Create(
       GURL("http://example.com"), "ABC", "DEF", "example.com", "/",
       base::Time(), base::Time(), false, false,
-      net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT));
+      net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
   ASSERT_NE(nullptr, cookie1.get());
   EXPECT_EQ("http://example.com/",
             cookies_helpers::GetURLFromCanonicalCookie(*cookie1).spec());
 
   std::unique_ptr<net::CanonicalCookie> cookie2(net::CanonicalCookie::Create(
-      GURL("http://helloworld.com"), "ABC", "DEF", ".helloworld.com", "/",
+      GURL("https://helloworld.com"), "ABC", "DEF", ".helloworld.com", "/",
       base::Time(), base::Time(), true, false,
-      net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT));
+      net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
   ASSERT_NE(nullptr, cookie2.get());
   EXPECT_EQ("https://helloworld.com/",
             cookies_helpers::GetURLFromCanonicalCookie(*cookie2).spec());
 }
 
 TEST_F(ExtensionCookiesTest, EmptyDictionary) {
   base::DictionaryValue dict;
   GetAll::Params::Details details;
   bool rv = GetAll::Params::Details::Populate(dict, &details);
   ASSERT_TRUE(rv);
@@ skipping 17 matching lines @@
     base::ListValue args;
     base::DictionaryValue* dict = new base::DictionaryValue();
     dict->SetString(keys::kDomainKey, std::string(tests[i].filter));
     args.Set(0, dict);
     std::unique_ptr<GetAll::Params> params(GetAll::Params::Create(args));
 
     cookies_helpers::MatchFilter filter(&params->details);
     std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
         GURL(tests[i].url), std::string(), std::string(), tests[i].domain,
         std::string(), base::Time(), base::Time(), false, false,
-        net::CookieSameSite::DEFAULT_MODE, false,
-        net::COOKIE_PRIORITY_DEFAULT));
+        net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
     ASSERT_NE(nullptr, cookie.get());
     EXPECT_EQ(tests[i].matches, filter.MatchesCookie(*cookie));
   }
 }
 
 TEST_F(ExtensionCookiesTest, DecodeUTF8WithErrorHandling) {
   std::unique_ptr<net::CanonicalCookie> canonical_cookie(
       net::CanonicalCookie::Create(GURL("http://test.com"),
                                    "=011Q255bNX_1!yd\203e+;path=/path\203",
                                    base::Time(), net::CookieOptions()));
   ASSERT_NE(nullptr, canonical_cookie.get());
   Cookie cookie =
       cookies_helpers::CreateCookie(*canonical_cookie, "some cookie store");
   EXPECT_EQ(std::string("011Q255bNX_1!yd\xEF\xBF\xBD"
                         "e+"),
             cookie.value);
   EXPECT_EQ(std::string(), cookie.path);
 }
 
 }  // namespace extensions