Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2633633002: Polymer: Remove unused app-layout element (Closed)

Created:
3 years, 11 months ago by tsergeant
Modified:
3 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, jlklein+watch-closure_chromium.org, dcheng, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-downloads_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer: Remove unused app-layout element BUG=629808 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2633633002 Cr-Commit-Position: refs/heads/master@{#444858} Committed: https://chromium.googlesource.com/chromium/src/+/44ed361a0e940d4cff7b5a91ecf1fb4ac96b38f7

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Fix closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3424 lines) Patch
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/bower.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-box/app-box.html View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-box/app-box-extracted.js View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-box/compiled_resources2.gyp View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/app-drawer-layout.html View 1 chunk +0 lines, -146 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/app-drawer-layout-extracted.js View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/compiled_resources2.gyp View 1 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/app-drawer.html View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/app-drawer-extracted.js View 1 chunk +0 lines, -492 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/compiled_resources2.gyp View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/app-header-layout.html View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/app-header-layout-extracted.js View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/compiled_resources2.gyp View 1 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-header/app-header.html View 1 chunk +0 lines, -318 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-header/app-header-extracted.js View 1 chunk +0 lines, -397 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-header/compiled_resources2.gyp View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-layout.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/app-scroll-effects.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/app-scroll-effects-behavior.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/app-scroll-effects-behavior-extracted.js View 1 chunk +0 lines, -348 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/compiled_resources2.gyp View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/blend-background.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/blend-background-extracted.js View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/compiled_resources2.gyp View 1 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/fade-background.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/fade-background-extracted.js View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/material.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/material-extracted.js View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/parallax-background.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/parallax-background-extracted.js View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-snapped-title.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-snapped-title-extracted.js View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-title.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-title-extracted.js View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/waterfall.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/waterfall-extracted.js View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/app-scrollpos-control.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/app-scrollpos-control-extracted.js View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/compiled_resources2.gyp View 1 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/app-toolbar.html View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/app-toolbar-extracted.js View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/compiled_resources2.gyp View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/bower.json View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/compiled_resources2.gyp View 1 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/helpers/compiled_resources2.gyp View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js View 1 chunk +0 lines, -115 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
tsergeant
PTAL! History was the only user of this element, and it was removed in https://codereview.chromium.org/2627383002/
3 years, 11 months ago (2017-01-18 06:26:13 UTC) #4
michaelpg
lgtm, but why the re-vulcanization? https://codereview.chromium.org/2633633002/diff/1/chrome/browser/resources/md_downloads/vulcanized.html File chrome/browser/resources/md_downloads/vulcanized.html (left): https://codereview.chromium.org/2633633002/diff/1/chrome/browser/resources/md_downloads/vulcanized.html#oldcode506 chrome/browser/resources/md_downloads/vulcanized.html:506: ; ..?
3 years, 11 months ago (2017-01-18 07:27:45 UTC) #5
tsergeant
Vulcanize is run by reproduce.sh. Not sure why that specific change was necessary, but I ...
3 years, 11 months ago (2017-01-19 02:34:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633633002/40001
3 years, 11 months ago (2017-01-19 22:08:06 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 22:16:53 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/44ed361a0e940d4cff7b5a91ecf1...

Powered by Google App Engine
This is Rietveld 408576698