Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2633593002: Do not require ContentSubresourceFilterDriverFactory (Closed)

Created:
3 years, 11 months ago by sgurun-gerrit only
Modified:
3 years, 11 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not require ContentSubresourceFilterDriverFactory Some content embedders (such as WebView) may not have a ContentSubresourceFilterDriverFactory created. Do not enforce it. BUG=680791 Review-Url: https://codereview.chromium.org/2633593002 Cr-Commit-Position: refs/heads/master@{#443496} Committed: https://chromium.googlesource.com/chromium/src/+/ad3a8033e026174e6341e2f7bb08054c93dc2b43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M components/safe_browsing/base_resource_throttle.cc View 1 chunk +15 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sgurun-gerrit only
On 2017/01/13 00:13:36, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:jialiul@chromium.org ptal, thanks
3 years, 11 months ago (2017-01-13 00:13:43 UTC) #3
Jialiu Lin
lgtm
3 years, 11 months ago (2017-01-13 00:19:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633593002/1
3 years, 11 months ago (2017-01-13 00:20:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/363291)
3 years, 11 months ago (2017-01-13 01:56:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633593002/1
3 years, 11 months ago (2017-01-13 03:08:43 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 05:05:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad3a8033e026174e6341e2f7bb08...

Powered by Google App Engine
This is Rietveld 408576698