|
Revert of Remove ForceReclaimResources (patchset #8 id:170001 of https://codereview.chromium.org/2609253003/ )
Reason for revert:
This has introduced flakiness into TextureLayerImplWithMailboxThreadedCallback.RunMultiThread_DelegatingRenderer, will address this and re-land.
Original issue's description:
> Remove ForceReclaimResources
>
> We had previously added ForceReclaimResources to BeginCommit to throttle
> frame output and prevent starving the display compositor's rasterization
> tasks. Unfortunately, this introduces significant overhead as well.
>
> With the addition of the Display Scheduler, this change no longer
> appears to be needed. The scheduler has independent controls for
> limiting the number of pending frames, and these should be used instead
> (if further tweaking is necessary).
>
> Removing this logic does not regress the benchmarks which it was
> initially added for, and seems unneeded at this point. Removing.
>
> R=reveman@chromium.org
> BUG= 676852, 489515, 617268
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2609253003
> Cr-Commit-Position: refs/heads/master@{#443061}
> Committed: https://chromium.googlesource.com/chromium/src/+/dc1892fc0639464d4418ccfaedfd1f95a5b947d0
TBR=reveman@chromium.org,danakj@chromium.org,enne@chromium.org,tommi@chromium.org,brianderson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 676852, 489515, 617268, 681093, 680770
Review-Url: https://codereview.chromium.org/2633563003
Cr-Commit-Position: refs/heads/master@{#443709}
Committed: https://chromium.googlesource.com/chromium/src/+/4b443521bc4bc46b4bd1537910f089fbf1578273
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+158 lines, -75 lines) |
Patch |
 |
M |
cc/layers/texture_layer_unittest.cc
|
View
|
|
3 chunks |
+8 lines, -13 lines |
0 comments
|
Download
|
 |
M |
cc/output/compositor_frame_sink.h
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
cc/surfaces/direct_compositor_frame_sink.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cc/surfaces/direct_compositor_frame_sink.cc
|
View
|
|
3 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/surfaces/direct_compositor_frame_sink_unittest.cc
|
View
|
|
1 chunk |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/surfaces/surface.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cc/surfaces/surface.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/surfaces/surface_factory.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/surfaces/surface_factory.cc
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/test/layer_tree_pixel_test.cc
|
View
|
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/test/layer_tree_test.cc
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/test/test_compositor_frame_sink.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/test/test_compositor_frame_sink.cc
|
View
|
|
3 chunks |
+14 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl.cc
|
View
|
|
2 chunks |
+12 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl_unittest.cc
|
View
|
|
2 chunks |
+28 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_pixeltest_tiles.cc
|
View
|
|
3 chunks |
+5 lines, -25 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest.cc
|
View
|
|
8 chunks |
+30 lines, -9 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/render_widget_compositor.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/test/layouttest_support.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/compositor/layer_unittest.cc
|
View
|
|
1 chunk |
+3 lines, -7 lines |
0 comments
|
Download
|
Total messages: 7 (4 generated)
|