Record data: URL metrics for mime types that can run JavaScript.

Record data: URL metrics for mime types that can run JavaScript.

BUG=680822
Review-Url: https://codereview.chromium.org/2633523003
Cr-Commit-Position: refs/heads/master@{#443644}
Committed: https://chromium.googlesource.com/chromium/src/+/4a2fca19b3bfdb2783f75faa9c4f66fa1437a18a

[meacer, 2017-01-13 03:04:58]

meacer@chromium.org changed reviewers:
+ avi@chromium.org

[meacer, 2017-01-13 03:04:59]

avi: PTAL?

[Avi (use Gerrit), 2017-01-13 16:52:52]

lgtm

https://codereview.chromium.org/2633523003/diff/20001/chrome/browser/tab_cont...
File chrome/browser/tab_contents/navigation_metrics_recorder.cc (right):

https://codereview.chromium.org/2633523003/diff/20001/chrome/browser/tab_cont...
chrome/browser/tab_contents/navigation_metrics_recorder.cc:52: LOG(ERROR) << ">>
MIME TYPE: " << mime_type;
You need to remove logging lines before committing.

[meacer, 2017-01-13 18:37:12]

asvitkine: PTAL at histograms.xml. Thanks.

https://codereview.chromium.org/2633523003/diff/20001/chrome/browser/tab_cont...
File chrome/browser/tab_contents/navigation_metrics_recorder.cc (right):

https://codereview.chromium.org/2633523003/diff/20001/chrome/browser/tab_cont...
chrome/browser/tab_contents/navigation_metrics_recorder.cc:52: LOG(ERROR) << ">>
MIME TYPE: " << mime_type;
On 2017/01/13 16:52:52, Avi (offsites OOO 17Jan-2Feb) wrote:
> You need to remove logging lines before committing.

Done.

[meacer, 2017-01-13 18:37:30]

meacer@chromium.org changed reviewers:
+ asvitkine@chromium.org

[meacer, 2017-01-13 18:37:31]

+asvitkine for histograms.xml

[Alexei Svitkine (slow), 2017-01-13 18:41:26]

lgtm

https://codereview.chromium.org/2633523003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2633523003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:28932: +    The mime type of the data:
URL for each main-frame navigation. This     only
Nit: Remove extra whitespace between This and only

[meacer, 2017-01-13 18:43:37]

The CQ bit was checked by meacer@chromium.org

[meacer, 2017-01-13 18:43:38]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2633523003/#ps60001
(title: "Remove extra whitespace")

[commit-bot: I haz the power, 2017-01-13 18:44:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 19:58:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484333017652250,
"parent_rev": "2fc6af94465bf4c86d723bab970f37f29ee3f944", "commit_rev":
"4a2fca19b3bfdb2783f75faa9c4f66fa1437a18a"}

[commit-bot: I haz the power, 2017-01-13 19:58:51]

Description was changed from

==========
Record data: URL metrics for mime types that can run JavaScript.

BUG=680822
==========

to

==========
Record data: URL metrics for mime types that can run JavaScript.

BUG=680822

Review-Url: https://codereview.chromium.org/2633523003
Cr-Commit-Position: refs/heads/master@{#443644}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a2fca19b3bfdb2783f75faa9c4f...
==========

[commit-bot: I haz the power, 2017-01-13 19:58:53]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4a2fca19b3bfdb2783f75faa9c4f...