Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2633463006: HeapCompact doesn't need to support multiple threads (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HeapCompact doesn't need to support multiple threads Now that the per-thread heaps have been shipped, HeapCompact no longer needs to support multiple threads. This CL removes that code. BUG=671856 Review-Url: https://codereview.chromium.org/2633463006 Cr-Commit-Position: refs/heads/master@{#443542} Committed: https://chromium.googlesource.com/chromium/src/+/6422f3b2391675817cc28ed311776067853f5757

Patch Set 1 #

Total comments: 1

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -49 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapCompact.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapCompact.cpp View 1 4 chunks +18 lines, -37 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-13 09:26:34 UTC) #3
sof
lgtm https://codereview.chromium.org/2633463006/diff/1/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2633463006/diff/1/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode454 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:454: // Compaction has been completed by all participating ...
3 years, 11 months ago (2017-01-13 09:36:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633463006/20001
3 years, 11 months ago (2017-01-13 09:49:48 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 12:46:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6422f3b2391675817cc28ed31177...

Powered by Google App Engine
This is Rietveld 408576698