Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2633413002: cros: Remove BaseScreen::Initialize method. (Closed)

Created:
3 years, 11 months ago by jdufault
Modified:
3 years, 11 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Remove BaseScreen::Initialize method. I'm not sure what the long term plan with this method was, but it looks like we can just move all of the associated work it did to the constructor to achieve the same effect. BUG=672142 Review-Url: https://codereview.chromium.org/2633413002 Cr-Commit-Position: refs/heads/master@{#444130} Committed: https://chromium.googlesource.com/chromium/src/+/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -50 lines) Patch
M chrome/browser/chromeos/login/screens/base_screen.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
jdufault
achuith@, PTAL.
3 years, 11 months ago (2017-01-17 20:12:27 UTC) #7
achuithb
On 2017/01/17 20:12:27, jdufault wrote: > achuith@, PTAL. lgtm
3 years, 11 months ago (2017-01-17 20:26:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633413002/1
3 years, 11 months ago (2017-01-17 20:36:54 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 20:42:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdbfd4cabc0df6eb1c945ca4ee59...

Powered by Google App Engine
This is Rietveld 408576698