Issue 263333004: Add timelineOffset() support to WebMediaPlayerAndroid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263333004: Add timelineOffset() support to WebMediaPlayerAndroid. (Closed)

Created:
6 years, 7 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 7 months ago

Reviewers:
qinmin

CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add timelineOffset() support to WebMediaPlayerAndroid. Adding minimal timelineOffset() support to Android so Blink can report this information via HTMLMediaElement.getStartDate() for MSE playbacks. BUG=312699 TESTS=Will be covered by the getStartDate() LayoutTests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268426

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -0 lines)			Patch
M	content/renderer/media/android/media_source_delegate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/media/android/media_source_delegate.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	content/renderer/media/android/webmediaplayer_android.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/android/webmediaplayer_android.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

This change is in support of adding getStartDate() support to HTMLMediaElement. (https://codereview.chromium.org/209223002/) .

6 years, 7 months ago (2014-05-06 00:06:45 UTC) #1

acolwell GONE FROM CHROMIUM

The CQ bit was checked by acolwell@chromium.org

6 years, 7 months ago (2014-05-06 00:22:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/263333004/1

6 years, 7 months ago (2014-05-06 00:24:17 UTC) #4

Message was sent while issue was closed.

Change committed as 268426

Expand Messages | Collapse Messages