Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2633293003: Remove TestingPlatformMockScheduler (Closed)

Created:
3 years, 11 months ago by Takashi Toyoshima
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TestingPlatformMockScheduler Since TestingPlatformMockScheduler is used only in IdleDeadlineTest, this patch removes TestingPlatformMockScheduler from TestingPlatformSupport, and implements it directly inside IdleDeadlineTest as MockScheduler. This will also help to avoid misunderstanding that TestingPlatformSupportWithMockScheduler uses TestingPlatformMockScheduler. Actually, it uses scheduler::RendererSchedulerImpl with cc::OrderedSimpleTaskRunner. BUG=655920 Review-Url: https://codereview.chromium.org/2633293003 Cr-Commit-Position: refs/heads/master@{#444025} Committed: https://chromium.googlesource.com/chromium/src/+/2ef6d3ba0eecb7bbc12671f83ac8adfea0b9c00b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp View 1 chunk +19 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Takashi Toyoshima
Can you review this change?
3 years, 11 months ago (2017-01-17 09:17:41 UTC) #6
haraken
LGTM
3 years, 11 months ago (2017-01-17 09:19:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633293003/1
3 years, 11 months ago (2017-01-17 11:21:07 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 11:25:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ef6d3ba0eecb7bbc12671f83ac8...

Powered by Google App Engine
This is Rietveld 408576698