Move MediaStream m_scheduledEventTimer to TaskRunnerTimer

Move MediaStream m_scheduledEventTimer to TaskRunnerTimer

Move MediaStream's m_scheduledEventTimer to TaskRunnerTimer, which
associates it wuith the frame's timer task queue.

Spec that defines media element event tasks:
https://html.spec.whatwg.org/#media-elements

BUG=624694
Review-Url: https://codereview.chromium.org/2633273002
Cr-Commit-Position: refs/heads/master@{#444231}
Committed: https://chromium.googlesource.com/chromium/src/+/88f7b1a466df5baaf320fc809190d88ac2b5ebfe

[sashab, 2017-01-17 04:29:03]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 04:29:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-17 04:29:22]

sashab@chromium.org changed reviewers:
+ joelhockey@chromium.org

[sashab, 2017-01-17 04:29:23]

Ptal joel. Thanks! :-)

[haraken, 2017-01-17 05:06:25]

Per the spec (https://html.spec.whatwg.org/#media-elements), I think MediaStream
should use the media element event task source.

[sashab, 2017-01-17 05:27:33]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2017-01-17 05:27:36]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 05:27:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-17 05:29:50]

Hi haraken! Thanks for the feedback. Out of interest what part of the spec are
you referring to, that makes it obvious that MediaStream is referring to the
spec'd events? Thanks

[joelhockey, 2017-01-17 06:25:49]

On 2017/01/17 at 04:29:23, sashab wrote:
> Ptal joel. Thanks! :-)

You are creating m_scheduledEventTimer as UnspeccedTimer (line 103) and as
MediaElementEvent (line 136).  Why different types?

[sashab, 2017-01-17 06:27:01]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 06:27:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-17 06:27:53]

Ahh, good find thanks! My mistake :) PTAL

[sashab, 2017-01-17 06:36:40]

Description was changed from

==========
Move MediaStream m_scheduledEventTimer to TaskRunnerTimer

Move MediaStream's m_scheduledEventTimer to TaskRunnerTimer, which
associates it wuith the frame's timer task queue.

BUG=624694
==========

to

==========
Move MediaStream m_scheduledEventTimer to TaskRunnerTimer

Move MediaStream's m_scheduledEventTimer to TaskRunnerTimer, which
associates it wuith the frame's timer task queue.

Spec that defines media element event tasks:
https://html.spec.whatwg.org/#media-elements

BUG=624694
==========

[sashab, 2017-01-17 06:36:54]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2017-01-17 06:36:55]

Haraken ptal :)

Added link to spec in CL description

[haraken, 2017-01-17 06:43:19]

LGTM

[joelhockey, 2017-01-17 06:52:05]

joelhockey@chromium.org changed reviewers:
- haraken@chromium.org

[joelhockey, 2017-01-17 06:52:05]

lgtm

[sashab, 2017-01-17 07:40:24]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2017-01-17 07:40:25]

Ty joel & haraken! :)

[commit-bot: I haz the power, 2017-01-17 08:18:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 08:18:43]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-01-18 01:27:47]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:28:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 01:34:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484702867651880,
"parent_rev": "5949e051331c74dc1bc140b609a785e491858dd4", "commit_rev":
"88f7b1a466df5baaf320fc809190d88ac2b5ebfe"}

[commit-bot: I haz the power, 2017-01-18 01:34:32]

Description was changed from

==========
Move MediaStream m_scheduledEventTimer to TaskRunnerTimer

Move MediaStream's m_scheduledEventTimer to TaskRunnerTimer, which
associates it wuith the frame's timer task queue.

Spec that defines media element event tasks:
https://html.spec.whatwg.org/#media-elements

BUG=624694
==========

to

==========
Move MediaStream m_scheduledEventTimer to TaskRunnerTimer

Move MediaStream's m_scheduledEventTimer to TaskRunnerTimer, which
associates it wuith the frame's timer task queue.

Spec that defines media element event tasks:
https://html.spec.whatwg.org/#media-elements

BUG=624694

Review-Url: https://codereview.chromium.org/2633273002
Cr-Commit-Position: refs/heads/master@{#444231}
Committed:
https://chromium.googlesource.com/chromium/src/+/88f7b1a466df5baaf320fc809190...
==========

[commit-bot: I haz the power, 2017-01-18 01:34:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/88f7b1a466df5baaf320fc809190...