Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2633243003: Use ARC for Suggestions tests (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ARC for Suggestions tests BUG=679369 Review-Url: https://codereview.chromium.org/2633243003 Cr-Commit-Position: refs/heads/master@{#444068} Committed: https://chromium.googlesource.com/chromium/src/+/0eaba9df22671feb4ac013ec4257e053666d94fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M ios/chrome/browser/ui/suggestions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/suggestions/suggestions_article_item_unittest.mm View 1 chunk +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/suggestions/suggestions_expandable_item_unittest.mm View 1 chunk +4 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/suggestions/suggestions_item_unittest.mm View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-17 13:21:56 UTC) #2
lpromero
Oh, all these tests were leaking memory… lgtm
3 years, 11 months ago (2017-01-17 13:52:41 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2625693002 Patch 180001). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-17 13:55:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633243003/1
3 years, 11 months ago (2017-01-17 15:38:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0eaba9df22671feb4ac013ec4257e053666d94fc
3 years, 11 months ago (2017-01-17 16:29:53 UTC) #13
Wez
Hallo rohitrao@chromium.org! Due to a depot_tools patch which mistakenly removed the OWNERS check for non-source ...
3 years, 10 months ago (2017-02-07 19:55:18 UTC) #15
rohitrao (ping after 24h)
3 years, 10 months ago (2017-02-07 19:58:36 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698