Convert CSSProperties.in to JSON5 format

Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/ since
it only requires -webkit-text-emphasis-* now (thanks to tkent@ for info)

BUG=677884, 614955
Review-Url: https://codereview.chromium.org/2633223003
Cr-Commit-Position: refs/heads/master@{#446574}
Committed: https://chromium.googlesource.com/chromium/src/+/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65

[ktyliu, 2017-01-17 01:21:32]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 01:21:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-17 01:24:24]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-17 01:24:25]

lgtm

[tkent, 2017-01-17 01:31:13]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2017-01-17 01:31:14]

https://codereview.chromium.org/2633223003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py (right):

https://codereview.chromium.org/2633223003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py:91:
self.prefixed_properties = self.read_webkit_prefixed_css_property_list()
Does read_webkit_prefixe_css_property_list work for json5?

BTW, we need only -webkit-text-emphasis here. We can stop referring to
CSSProperties.in by handling only -webkit-text-emphasis.
See https://bugs.chromium.org/p/chromium/issues/detail?id=614955#c1

[commit-bot: I haz the power, 2017-01-17 01:37:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 01:37:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-17 02:39:39]

Thanks, Kent, for pointing out that only one -webkit property is required in
webkitpy/w3c/test_convert.py

This CL actually wasn't ready for review yet, with that particular script
previously not fully converted and also
third_party/WebKit/Source/devtools/BUILD.gn not reusing the json5 library.

I was just doing git-cl try to uncover remaining issues but thanks to Kent and
Sasha for the quick review

https://codereview.chromium.org/2633223003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py (right):

https://codereview.chromium.org/2633223003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py:91:
self.prefixed_properties = self.read_webkit_prefixed_css_property_list()
Thanks for pointing out only -webkit-text-emphasis is needed.
Modify the code to just use that directly and removed reference to CSSProperties

[ktyliu, 2017-01-17 02:42:34]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 02:42:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 02:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 02:53:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-01-17 03:14:53]

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py (right):

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py:92:
self.prefixed_properties = ['-webkit-text-emphasis']
I'm sorry, but we need more property names:
 -webkit-text-emphasis
 -webkit-text-emphasis-style
 -webkit-text-emphasis-position

https://cs.chromium.org/search/?q=webkit-+file:imported/csswg-test&sq=package...

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
(right):

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:137:
'/mock-checkout/third_party/WebKit/Source/core/css/CSSProperties.json5': '',
I think we don't need this line because test_converter doesn't read it.

[tkent, 2017-01-17 03:16:05]

Description was changed from

==========
Convert CSSProprerties.in to JSON5

BUG=677884
==========

to

==========
Convert CSSProprerties.in to JSON5

BUG=677884, 614955
==========

[tkent, 2017-01-17 03:16:50]

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py (right):

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py:92:
self.prefixed_properties = ['-webkit-text-emphasis']
On 2017/01/17 at 03:14:53, tkent wrote:
> I'm sorry, but we need more property names:
>  -webkit-text-emphasis
>  -webkit-text-emphasis-style
>  -webkit-text-emphasis-position
> 
>
https://cs.chromium.org/search/?q=webkit-+file:imported/csswg-test&sq=package...

-webkit-text-emphasis-color too :)

[ktyliu, 2017-01-17 03:43:33]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 03:43:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-17 03:50:25]

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py (right):

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py:92:
self.prefixed_properties = ['-webkit-text-emphasis']
On 2017/01/17 at 03:16:50, tkent wrote:
> On 2017/01/17 at 03:14:53, tkent wrote:
> > I'm sorry, but we need more property names:
> >  -webkit-text-emphasis
> >  -webkit-text-emphasis-style
> >  -webkit-text-emphasis-position
> > 
> >
https://cs.chromium.org/search/?q=webkit-+file:imported/csswg-test&sq=package...
> 
> -webkit-text-emphasis-color too :)

Done :)

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
(right):

https://codereview.chromium.org/2633223003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:137:
'/mock-checkout/third_party/WebKit/Source/core/css/CSSProperties.json5': '',
On 2017/01/17 at 03:14:53, tkent wrote:
> I think we don't need this line because test_converter doesn't read it.

Good catch.
Done.

[commit-bot: I haz the power, 2017-01-17 04:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 04:57:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-01-17 07:02:52]

lgtm

[ktyliu, 2017-01-25 00:56:14]

Description was changed from

==========
Convert CSSProprerties.in to JSON5

BUG=677884, 614955
==========

to

==========
Convert CSSProprerties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/

BUG=677884, 614955
==========

[ktyliu, 2017-01-25 00:57:08]

Description was changed from

==========
Convert CSSProprerties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/

BUG=677884, 614955
==========

to

==========
Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/

BUG=677884, 614955
==========

[ktyliu, 2017-01-25 00:58:13]

Description was changed from

==========
Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/

BUG=677884, 614955
==========

to

==========
Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/ since
it only requires -webkit-text-emphasis-* now (thanks to tkent@ for info)

BUG=677884, 614955
==========

[ktyliu, 2017-01-25 00:58:25]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 00:59:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 01:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 01:04:21]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-25 04:42:34]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 04:42:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 07:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 07:36:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-01-26 20:54:20]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 20:54:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-26 20:56:08]

On 2017/01/17 at 07:02:52, tkent wrote:
> lgtm

Thanks.

Plan to submit this today, now that the batch changes to CSSProperties.in (for
project Ribbon) have landed.

[ktyliu, 2017-01-26 22:22:50]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-26 22:22:50]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2633223003/#ps150001
(title: "Remove unneeded CSSProperties.in in test_copier_unittest.py")

[commit-bot: I haz the power, 2017-01-26 22:23:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 23:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:26:45]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-26 23:31:56]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:33:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-27 00:39:00]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-27 00:39:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2633223003/#ps170001
(title: "Fix test_converter_unittest")

[commit-bot: I haz the power, 2017-01-27 00:40:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:35:22]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1485477540390020,
"parent_rev": "8607d9dbd5cc0fc0af61580e7af0f92509bec5d0", "commit_rev":
"6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65"}

[commit-bot: I haz the power, 2017-01-27 03:35:53]

Description was changed from

==========
Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/ since
it only requires -webkit-text-emphasis-* now (thanks to tkent@ for info)

BUG=677884, 614955
==========

to

==========
Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/ since
it only requires -webkit-text-emphasis-* now (thanks to tkent@ for info)

BUG=677884, 614955

Review-Url: https://codereview.chromium.org/2633223003
Cr-Commit-Position: refs/heads/master@{#446574}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a5bbaea71e02af0b0bd60c7ba3e...
==========

[commit-bot: I haz the power, 2017-01-27 03:35:55]

Committed patchset #10 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/6a5bbaea71e02af0b0bd60c7ba3e...

[sashab, 2017-01-27 22:33:11]

\o/!!!!!!!!!!!