Enable field trial shared memory segment on Android.

Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file. Also reduces the !NACL ifdefs by defining an anon
wrapper around TerminateBecauseOutOfMemory() which doesn't exist for
NACL.

BUG=681695
Review-Url: https://codereview.chromium.org/2633203002
Cr-Commit-Position: refs/heads/master@{#445457}
Committed: https://chromium.googlesource.com/chromium/src/+/f8d5915aabda618649aea2495a8b08da938cb269

[Alexei Svitkine (slow), 2017-01-16 21:12:36]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 21:12:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 21:14:16]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform that didn't have this support, which
was added last fall for the other platforms. Turns out, it just
works (I tested this on a local build and verified that things
are working correctly and an induced chrome://crash report has
all the field trials and the expected command line flags).

This CL also cleans up all the ifdefs, which originally needed
to special case POSIX_WITH_ZYGOTE but no longer need to now.

The other platforms were enabled under crbug.com/663918

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform that didn't have this support, which
was added last fall for the other platforms. Turns out, it just
works (I tested this on a local build and verified that things
are working correctly via an induced chrome://crash which
had all the field trials and the expected command line flags).

This CL also cleans up all the ifdefs, which originally needed
to special case POSIX_WITH_ZYGOTE but no longer need to now.

The other platforms were enabled under crbug.com/663918

BUG=681695
==========

[Alexei Svitkine (slow), 2017-01-16 21:14:45]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform that didn't have this support, which
was added last fall for the other platforms. Turns out, it just
works (I tested this on a local build and verified that things
are working correctly via an induced chrome://crash which
had all the field trials and the expected command line flags).

This CL also cleans up all the ifdefs, which originally needed
to special case POSIX_WITH_ZYGOTE but no longer need to now.

The other platforms were enabled under crbug.com/663918

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform that didn't have this support, which was
added last fall for the other platforms. Turns out, it just works.

I tested this on a local build and verified that things are working
correctly via an induced chrome://crash which had all the field
trials and the expected command line flags.

This CL also cleans up all the ifdefs, which originally needed
to special case POSIX_WITH_ZYGOTE but no longer need to now.

The other platforms were enabled under crbug.com/663918

BUG=681695
==========

[Alexei Svitkine (slow), 2017-01-16 21:14:59]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2017-01-16 21:24:33]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 21:24:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 21:24:53]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform that didn't have this support, which was
added last fall for the other platforms. Turns out, it just works.

I tested this on a local build and verified that things are working
correctly via an induced chrome://crash which had all the field
trials and the expected command line flags.

This CL also cleans up all the ifdefs, which originally needed
to special case POSIX_WITH_ZYGOTE but no longer need to now.

The other platforms were enabled under crbug.com/663918

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this
support, which was added last fall for the other platforms.

Turns out, it just works.

I tested this on a local build and verified that things are working
correctly via an induced chrome://crash which had all the field
trials and the expected command line flags.

This CL also cleans up all the ifdefs, which originally needed
to special case POSIX_WITH_ZYGOTE but no longer need to now.

The other platforms were enabled under crbug.com/663918

BUG=681695
==========

[Alexei Svitkine (slow), 2017-01-16 21:25:45]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 21:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 21:28:55]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 21:29:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 21:30:43]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2017-01-16 21:30:51]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-16 21:42:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 21:42:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2017-01-16 22:10:02]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 22:10:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 22:12:34]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this
support, which was added last fall for the other platforms.

Turns out, it just works.

I tested this on a local build and verified that things are working
correctly via an induced chrome://crash which had all the field
trials and the expected command line flags.

This CL also cleans up all the ifdefs, which originally needed
to special case POSIX_WITH_ZYGOTE but no longer need to now.

The other platforms were enabled under crbug.com/663918

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this
support, which was added last fall for the other platforms.
The other platforms were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working
correctly via an induced chrome://crash which had all the field
trials and the expected command line flags.

This CL mostly cleans up the ifdefs to explicitly exclude IOS
and NACL from the POSIX codepath and moves one function
so that its order matches the header file.

BUG=681695
==========

[Alexei Svitkine (slow), 2017-01-16 22:13:16]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this
support, which was added last fall for the other platforms.
The other platforms were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working
correctly via an induced chrome://crash which had all the field
trials and the expected command line flags.

This CL mostly cleans up the ifdefs to explicitly exclude IOS
and NACL from the POSIX codepath and moves one function
so that its order matches the header file.

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs to explicitly exclude IOS and NACL from
the POSIX codepath and moves one function so that its order matches the
header file.

BUG=681695
==========

[commit-bot: I haz the power, 2017-01-16 22:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 22:17:15]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Alexei Svitkine (slow), 2017-01-16 22:34:56]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 22:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 22:39:07]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 22:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 22:42:37]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs to explicitly exclude IOS and NACL from
the POSIX codepath and moves one function so that its order matches the
header file.

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file.

BUG=681695
==========

[Alexei Svitkine (slow), 2017-01-16 22:48:13]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file.

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file. Also reduces the !NACL ifdefs by defining a
TerminateBecauseOutOfMemory() anon function which otherwise gives a
link error on NACL due to not existing.

BUG=681695
==========

[Alexei Svitkine (slow), 2017-01-16 22:49:36]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 22:49:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-16 22:50:26]

Patchset #3 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-01-16 23:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 23:02:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Alexei Svitkine (slow), 2017-01-17 15:59:03]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 15:59:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-17 16:03:03]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 16:03:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-17 16:04:46]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file. Also reduces the !NACL ifdefs by defining a
TerminateBecauseOutOfMemory() anon function which otherwise gives a
link error on NACL due to not existing.

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file. Also reduces the !NACL ifdefs by defining an anon
wrapper around TerminateBecauseOutOfMemory() which doesn't exist for
NACL.

BUG=681695
==========

[Alexei Svitkine (slow), 2017-01-17 16:04:56]

Patchset #3 (id:120001) has been deleted

[Alexei Svitkine (slow), 2017-01-17 16:05:03]

Patchset #3 (id:140001) has been deleted

[Alexei Svitkine (slow), 2017-01-17 16:05:12]

Patchset #1 (id:60001) has been deleted

[Alexei Svitkine (slow), 2017-01-17 16:05:22]

Patchset #1 (id:80001) has been deleted

[Alexei Svitkine (slow), 2017-01-17 16:05:29]

Patchset #1 (id:160001) has been deleted

[commit-bot: I haz the power, 2017-01-17 16:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 16:15:09]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Alexei Svitkine (slow), 2017-01-17 16:46:36]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 16:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-17 17:17:35]

asvitkine@chromium.org changed reviewers:
+ bcwhite@chromium.org

[Alexei Svitkine (slow), 2017-01-17 17:17:51]

Patchset #1 (id:180001) has been deleted

[commit-bot: I haz the power, 2017-01-17 17:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 17:48:30]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-01-18 19:11:19]

bcwhite; friendly ping

[bcwhite, 2017-01-18 19:24:34]

lgtm

https://codereview.chromium.org/2633203002/diff/200001/base/metrics/field_tri...
File base/metrics/field_trial.cc (right):

https://codereview.chromium.org/2633203002/diff/200001/base/metrics/field_tri...
base/metrics/field_trial.cc:888: #else
How about:

#elif defined(OS_POSIX)
...
#else
#error Unsupported OS
#endif

[Alexei Svitkine (slow), 2017-01-18 20:05:02]

Thanks!

Looks like M57 branch point is this week, so I'll wait and land this after that
just to be safe.

https://codereview.chromium.org/2633203002/diff/200001/base/metrics/field_tri...
File base/metrics/field_trial.cc (right):

https://codereview.chromium.org/2633203002/diff/200001/base/metrics/field_tri...
base/metrics/field_trial.cc:888: #else
On 2017/01/18 19:24:34, bcwhite wrote:
> How about:
> 
> #elif defined(OS_POSIX)
> ...
> #else
> #error Unsupported OS
> #endif

Done.

[Alexei Svitkine (slow), 2017-01-18 20:05:08]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 20:05:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:13:53]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-01-23 17:51:40]

Looks like M57 has branched, so will be landing this.

[Alexei Svitkine (slow), 2017-01-23 17:51:50]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-01-23 17:51:51]

The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org
Link to the patchset: https://codereview.chromium.org/2633203002/#ps220001
(title: "Add #error Unsupported OS.")

[commit-bot: I haz the power, 2017-01-23 17:52:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:14:14]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1485193910722110,
"parent_rev": "5b3146e409fb25ffe5e45b9fe6c207abe86d04e1", "commit_rev":
"f8d5915aabda618649aea2495a8b08da938cb269"}

[commit-bot: I haz the power, 2017-01-23 20:14:47]

Description was changed from

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file. Also reduces the !NACL ifdefs by defining an anon
wrapper around TerminateBecauseOutOfMemory() which doesn't exist for
NACL.

BUG=681695
==========

to

==========
Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file. Also reduces the !NACL ifdefs by defining an anon
wrapper around TerminateBecauseOutOfMemory() which doesn't exist for
NACL.

BUG=681695

Review-Url: https://codereview.chromium.org/2633203002
Cr-Commit-Position: refs/heads/master@{#445457}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8d5915aabda618649aea2495a8b...
==========

[commit-bot: I haz the power, 2017-01-23 20:14:49]

Committed patchset #2 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/f8d5915aabda618649aea2495a8b...