Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h

Issue 2633143002: SVG objects with same idrefs conflict when under different shadow root (Closed)
Patch Set: ensureSVGTreeScopedResources(); add comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h
diff --git a/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h b/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h
new file mode 100644
index 0000000000000000000000000000000000000000..a58a438257bb1ce65983aac91773fd7a8ddbfdb0
--- /dev/null
+++ b/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h
@@ -0,0 +1,58 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SVGTreeScopeResources_h
+#define SVGTreeScopeResources_h
+
+#include "platform/heap/Handle.h"
+#include "wtf/Forward.h"
+#include "wtf/HashMap.h"
+#include "wtf/HashSet.h"
+#include "wtf/text/AtomicStringHash.h"
+
+namespace blink {
+
+class Element;
+class TreeScope;
+class LayoutSVGResourceContainer;
+
+// This class keeps track of SVG resources and pending references to such for a
+// TreeScope. It's per-TreeScope because that matches the lookup scope of an
+// element's id (which is used to identify a resource.)
+class SVGTreeScopeResources
+ : public GarbageCollectedFinalized<SVGTreeScopeResources> {
+ WTF_MAKE_NONCOPYABLE(SVGTreeScopeResources);
+
+ public:
+ typedef HeapHashSet<Member<Element>> SVGPendingElements;
+
+ explicit SVGTreeScopeResources(TreeScope*);
+ ~SVGTreeScopeResources();
+
+ void addResource(const AtomicString& id, LayoutSVGResourceContainer*);
+ void removeResource(const AtomicString& id);
+ LayoutSVGResourceContainer* resourceById(const AtomicString& id) const;
+
+ // Pending resources are such which are referenced by any object in the SVG
+ // document, but do NOT exist yet. For instance, dynamically built gradients
+ // / patterns / clippers...
+ void addPendingResource(const AtomicString& id, Element*);
+ bool hasPendingResource(const AtomicString& id) const;
+ bool isElementPendingResources(Element*) const;
+ bool isElementPendingResource(Element*, const AtomicString& id) const;
+ void clearHasPendingResourcesIfPossible(Element*);
+ void removeElementFromPendingResources(Element*);
+ SVGPendingElements* removePendingResource(const AtomicString& id);
+
+ DECLARE_TRACE();
+
+ private:
+ HashMap<AtomicString, LayoutSVGResourceContainer*> m_resources;
+ // Resources that are pending.
+ HeapHashMap<AtomicString, Member<SVGPendingElements>> m_pendingResources;
+};
+
+} // namespace blink
+
+#endif // SVGTreeScopeResources_h

Powered by Google App Engine
This is Rietveld 408576698