Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

Issue 2633143002: SVG objects with same idrefs conflict when under different shadow root (Closed)
Patch Set: ensureSVGTreeScopedResources(); add comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp
index eae5a2b6c12119c0f9d3fd5fad191734bc9cc3ef..c96236ea95041cdf6174d168dd67d981349aba4e 100644
--- a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp
@@ -21,7 +21,7 @@
#include "core/svg/SVGTextPathElement.h"
#include "core/layout/svg/LayoutSVGTextPath.h"
-#include "core/svg/SVGDocumentExtensions.h"
+#include "core/svg/SVGTreeScopeResources.h"
namespace blink {
@@ -127,12 +127,12 @@ void SVGTextPathElement::buildPendingResource() {
hrefString(), treeScope(), &id);
if (!target) {
// Do not register as pending if we are already pending this resource.
- if (document().accessSVGExtensions().isElementPendingResource(this, id))
+ if (treeScope().ensureSVGTreeScopedResources().isElementPendingResource(
+ this, id))
return;
-
if (!id.isEmpty()) {
- document().accessSVGExtensions().addPendingResource(id, this);
- ASSERT(hasPendingResources());
+ treeScope().ensureSVGTreeScopedResources().addPendingResource(id, this);
+ DCHECK(hasPendingResources());
}
} else if (isSVGPathElement(*target)) {
// Register us with the target in the dependencies map. Any change of
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGMPathElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698