Issue 26331009: Fix QuicConnectionHelper's alarm implementation

Issue 26331009: Fix QuicConnectionHelper's alarm implementation (Closed)

Created:
7 years, 2 months ago by Ryan Hamilton

Modified:
7 years, 2 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix QuicConnectionHelper's alarm implementation to properly allow alarms to be re-secheduled for an earlier time. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228641

Patch Set 2 : Fix comments #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -10 lines)			Patch
M	net/quic/quic_client_session.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection_helper.cc	View	1	4 chunks	+20 lines, -10 lines	0 comments	Download
M	net/quic/quic_connection_helper_test.cc	View		2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

LGTM %nit https://codereview.chromium.org/26331009/diff/1/net/quic/quic_connection_helper.cc File net/quic/quic_connection_helper.cc (right): https://codereview.chromium.org/26331009/diff/1/net/quic/quic_connection_helper.cc#newcode86 net/quic/quic_connection_helper.cc:86: // post a new task when the ...

7 years, 2 months ago (2013-10-12 21:05:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/26331009/6001

7 years, 2 months ago (2013-10-15 03:29:48 UTC) #3

Ryan Hamilton

7 years, 2 months ago (2013-10-15 20:58:44 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/26331009/diff/1/net/quic/quic_connection_help...
File net/quic/quic_connection_helper.cc (right):

https://codereview.chromium.org/26331009/diff/1/net/quic/quic_connection_help...
net/quic/quic_connection_helper.cc:86: // post a new task when the deadline is
in the past.
On 2013/10/12 21:05:04, jar wrote:
> nit: "...deadline is in the past" --> "...deadline is now earlier than when
> previously planned/posted."

Done.

Expand Messages | Collapse Messages