Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: net/quic/quic_client_session.cc

Issue 26331009: Fix QuicConnectionHelper's alarm implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.cc
diff --git a/net/quic/quic_client_session.cc b/net/quic/quic_client_session.cc
index 91584c05a4cc41b7184ee1dde2ffd7f28c9bb17d..8604294085e81998263cf69b7513d5cad11b278b 100644
--- a/net/quic/quic_client_session.cc
+++ b/net/quic/quic_client_session.cc
@@ -310,6 +310,7 @@ void QuicClientSession::OnCryptoHandshakeMessageReceived(
}
void QuicClientSession::ConnectionClose(QuicErrorCode error, bool from_peer) {
+ DCHECK(!connection()->connected());
logger_.OnConnectionClose(error, from_peer);
if (from_peer) {
UMA_HISTOGRAM_SPARSE_SLOWLY(
@@ -330,6 +331,7 @@ void QuicClientSession::ConnectionClose(QuicErrorCode error, bool from_peer) {
if (!callback_.is_null()) {
base::ResetAndReturn(&callback_).Run(ERR_QUIC_PROTOCOL_ERROR);
}
+ socket_->Close();
QuicSession::ConnectionClose(error, from_peer);
NotifyFactoryOfSessionCloseLater();
}
« no previous file with comments | « no previous file | net/quic/quic_connection_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698