Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2633083002: Reland of wptserve: Enable WPTServe by default. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, Rick Byers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2537413002/ ) Reason for revert: The problem was resolved. Original issue's description: > Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) > > Reason for revert: > I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. > > See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/13447/steps/webkit_tests/logs/stdio for an example. > > I'm speculatively reverting this for now, to see if things become happier. > > Original issue's description: > > Reland of wptserve: Enable WPTServe by default. > > TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org > NOTRY=true > NOPRESUBMIT=true > BUG=618366 > > Committed: https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5 > Cr-Commit-Position: refs/heads/master@{#435129} TBR=qyearsley@chromium.org,jsbell@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618366 Review-Url: https://codereview.chromium.org/2633083002 Cr-Commit-Position: refs/heads/master@{#443953} Committed: https://chromium.googlesource.com/chromium/src/+/01c97b5106a69c02931e5aee55e460e1e7eb398a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Created Reland of wptserve: Enable WPTServe by default.
3 years, 11 months ago (2017-01-16 03:38:15 UTC) #1
tkent
3 years, 11 months ago (2017-01-16 05:06:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633083002/1
3 years, 11 months ago (2017-01-16 22:22:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/01c97b5106a69c02931e5aee55e460e1e7eb398a
3 years, 11 months ago (2017-01-16 22:27:19 UTC) #11
qyearsley
3 years, 11 months ago (2017-01-17 17:01:35 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698