Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2633073002: Request to import editing/ and selection/ from web-platform-tests. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews, yosin_UTC9
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Request to import editing/ and selection/ from web-platform-tests. The next auto-import will import tests in them. NOTRY=true Review-Url: https://codereview.chromium.org/2633073002 Cr-Commit-Position: refs/heads/master@{#443844} Committed: https://chromium.googlesource.com/chromium/src/+/fd7c54b5c2775dc8d87c634e402b82d83aca2da1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
kochi@, would you review this please?
3 years, 11 months ago (2017-01-16 01:12:59 UTC) #3
kochi
LGTM FYI +cc yosin
3 years, 11 months ago (2017-01-16 04:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633073002/1
3 years, 11 months ago (2017-01-16 04:07:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fd7c54b5c2775dc8d87c634e402b82d83aca2da1
3 years, 11 months ago (2017-01-16 04:13:19 UTC) #9
tkent
3 years, 11 months ago (2017-01-17 08:06:54 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2631253003/ by tkent@chromium.org.

The reason for reverting is: Tests in these directories have too many problems,
and blocking WPT autoroller.

.

Powered by Google App Engine
This is Rietveld 408576698