Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2633003003: Update iron-overlay-behavior to version 1.10.2. (Closed)

Created:
3 years, 11 months ago by oka
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, jlklein+watch-closure_chromium.org, dcheng, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-downloads_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update iron-overlay-behavior to version 1.10.2. Files App's quick view is suffered from the bug https://github.com/PolymerElements/iron-overlay-behavior/pull/200, and focus doesn't move inside files-quick-view element if a button inside it is hidden. Updating iron-overlay-behavior fixes the issue. This CL was created by the following steps. 1. Change the version in third_party/polymer/v1_0/bower.json 2. Run third_party/polymer/v1_0/reproduce.sh 3. tools/polymer/polymer_grdp_to_txt.py ui/webui/resources/polymer_resources.grdp > polymer.txt vim polymer.txt # add iron-overlay-behavior/iron-focusables-helper{-extracted.js,.html} tools/polymer/txt_to_polymer_grdp.py polymer.txt > ui/webui/resources/polymer_resources.grdp BUG=663636 TEST=git cl try. third_party/closure_compiler/run_compiler. The issue mentioned above is fixed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2633003003 Cr-Commit-Position: refs/heads/master@{#444313} Committed: https://chromium.googlesource.com/chromium/src/+/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Update polymer_resources.grdp. #

Patch Set 4 : Add iron-focusables-helper-extracted.js to grdp. #

Patch Set 5 : Proper version #

Patch Set 6 : Used proper version of tools. #

Patch Set 7 : Add iron-focusable-helper #

Patch Set 8 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -182 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 3 4 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-box/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-header/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/helpers/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/font-roboto/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-announcer/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-fit-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-flex-layout/classes/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-flex-layout/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-iconset-svg/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-location/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-media-query/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-meta/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/compiled_resources2.gyp View 3 chunks +6 lines, -1 line 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-focusables-helper.html View 6 1 chunk +3 lines, -6 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-focusables-helper-extracted.js View 6 1 chunk +206 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js View 7 chunks +68 lines, -89 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-range-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-scroll-threshold/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-selector/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-behaviors/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-button/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-drawer-panel/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-listbox/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-group/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/classes/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toolbar/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tooltip/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 52 (39 generated)
oka
Rebased.
3 years, 11 months ago (2017-01-16 07:55:44 UTC) #5
oka
PTAL.
3 years, 11 months ago (2017-01-16 08:43:04 UTC) #10
oka
Update polymer_resources.grdp.
3 years, 11 months ago (2017-01-16 15:05:26 UTC) #19
oka
Add iron-focusables-helper-extracted.js to grdp.
3 years, 11 months ago (2017-01-16 16:26:19 UTC) #25
Dan Beam
hey oka@: did you make sure that your versions of crisper, vulcanize, polymer-css-build, and uglifyjs ...
3 years, 11 months ago (2017-01-17 19:12:13 UTC) #31
oka
Proper version
3 years, 11 months ago (2017-01-18 04:48:39 UTC) #32
oka
Used proper version of tools.
3 years, 11 months ago (2017-01-18 05:01:20 UTC) #33
oka
I made sure to use proper version of tools (crisper etc.). PTAL.
3 years, 11 months ago (2017-01-18 05:03:06 UTC) #34
oka
Add iron-focusable-helper
3 years, 11 months ago (2017-01-18 05:05:19 UTC) #35
Dan Beam
lgtm
3 years, 11 months ago (2017-01-18 05:23:22 UTC) #40
oka
Rebased.
3 years, 11 months ago (2017-01-18 08:27:22 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633003003/140001
3 years, 11 months ago (2017-01-18 08:28:36 UTC) #49
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 09:35:05 UTC) #52
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/3666a6adbabb30d6d4f2fc53ebf7...

Powered by Google App Engine
This is Rietveld 408576698