Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2632953003: Remove unused arg temp_repo_path in DepsUpdater._generate_manifest. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused arg temp_repo_path in DepsUpdater._generate_manifest. BUG=643937 Review-Url: https://codereview.chromium.org/2632953003 Cr-Commit-Position: refs/heads/master@{#444521} Committed: https://chromium.googlesource.com/chromium/src/+/8d3b263c6e8053d2447b4ce008ec0e793c40e5f5

Patch Set 1 #

Patch Set 2 : git co use-local-wpt #

Patch Set 3 : Update test #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
qyearsley
3 years, 11 months ago (2017-01-15 23:30:47 UTC) #2
jeffcarp
lgtm
3 years, 11 months ago (2017-01-18 20:22:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632953003/60001
3 years, 11 months ago (2017-01-18 22:35:56 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 22:43:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8d3b263c6e8053d2447b4ce008ec...

Powered by Google App Engine
This is Rietveld 408576698