Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: media/cast/logging/log_deserializer.cc

Issue 263293003: Cast: Fix a bug with indexing in LogDeserializer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/log_deserializer.cc
diff --git a/media/cast/logging/log_deserializer.cc b/media/cast/logging/log_deserializer.cc
index 5621be032122d5145773260489417acc04f949e4..a4c79b3de950bef74568ab7c220525c0509989d5 100644
--- a/media/cast/logging/log_deserializer.cc
+++ b/media/cast/logging/log_deserializer.cc
@@ -33,7 +33,7 @@ void MergePacketEvent(const AggregatedPacketEvent& from,
const BasePacketEvent& from_base_event = from.base_packet_event(i);
bool merged = false;
for (int j = 0; j < to->base_packet_event_size(); j++) {
- BasePacketEvent* to_base_event = to->mutable_base_packet_event(i);
+ BasePacketEvent* to_base_event = to->mutable_base_packet_event(j);
if (from_base_event.packet_id() == to_base_event->packet_id()) {
to_base_event->MergeFrom(from_base_event);
merged = true;
@@ -51,12 +51,14 @@ void MergeFrameEvent(const AggregatedFrameEvent& from,
linked_ptr<AggregatedFrameEvent> to) {
to->mutable_event_type()->MergeFrom(from.event_type());
to->mutable_event_timestamp_ms()->MergeFrom(from.event_timestamp_ms());
- if (!to->has_encoded_frame_size())
+ if (!to->has_encoded_frame_size() && from.has_encoded_frame_size())
to->set_encoded_frame_size(from.encoded_frame_size());
- if (!to->has_delay_millis())
+ if (!to->has_delay_millis() && from.has_delay_millis())
to->set_delay_millis(from.delay_millis());
- if (!to->has_key_frame())
+ if (!to->has_key_frame() && from.has_key_frame())
to->set_key_frame(from.key_frame());
+ if (!to->has_target_bitrate() && from.has_target_bitrate())
+ to->set_target_bitrate(from.target_bitrate());
}
bool PopulateDeserializedLog(base::BigEndianReader* reader,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698