Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: media/cast/logging/log_deserializer.cc

Issue 263293003: Cast: Fix a bug with indexing in LogDeserializer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/logging/log_deserializer.h" 5 #include "media/cast/logging/log_deserializer.h"
6 6
7 #include <map> 7 #include <map>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/big_endian.h" 10 #include "base/big_endian.h"
(...skipping 15 matching lines...) Expand all
26 // since the there are two streams in the blob. 26 // since the there are two streams in the blob.
27 // Keep in sync with media/cast/logging/log_serializer.cc. 27 // Keep in sync with media/cast/logging/log_serializer.cc.
28 const int kMaxUncompressedBytes = 60 * 1000 * 1000; 28 const int kMaxUncompressedBytes = 60 * 1000 * 1000;
29 29
30 void MergePacketEvent(const AggregatedPacketEvent& from, 30 void MergePacketEvent(const AggregatedPacketEvent& from,
31 linked_ptr<AggregatedPacketEvent> to) { 31 linked_ptr<AggregatedPacketEvent> to) {
32 for (int i = 0; i < from.base_packet_event_size(); i++) { 32 for (int i = 0; i < from.base_packet_event_size(); i++) {
33 const BasePacketEvent& from_base_event = from.base_packet_event(i); 33 const BasePacketEvent& from_base_event = from.base_packet_event(i);
34 bool merged = false; 34 bool merged = false;
35 for (int j = 0; j < to->base_packet_event_size(); j++) { 35 for (int j = 0; j < to->base_packet_event_size(); j++) {
36 BasePacketEvent* to_base_event = to->mutable_base_packet_event(i); 36 BasePacketEvent* to_base_event = to->mutable_base_packet_event(j);
37 if (from_base_event.packet_id() == to_base_event->packet_id()) { 37 if (from_base_event.packet_id() == to_base_event->packet_id()) {
38 to_base_event->MergeFrom(from_base_event); 38 to_base_event->MergeFrom(from_base_event);
39 merged = true; 39 merged = true;
40 break; 40 break;
41 } 41 }
42 } 42 }
43 if (!merged) { 43 if (!merged) {
44 BasePacketEvent* to_base_event = to->add_base_packet_event(); 44 BasePacketEvent* to_base_event = to->add_base_packet_event();
45 to_base_event->CopyFrom(from_base_event); 45 to_base_event->CopyFrom(from_base_event);
46 } 46 }
47 } 47 }
48 } 48 }
49 49
50 void MergeFrameEvent(const AggregatedFrameEvent& from, 50 void MergeFrameEvent(const AggregatedFrameEvent& from,
51 linked_ptr<AggregatedFrameEvent> to) { 51 linked_ptr<AggregatedFrameEvent> to) {
52 to->mutable_event_type()->MergeFrom(from.event_type()); 52 to->mutable_event_type()->MergeFrom(from.event_type());
53 to->mutable_event_timestamp_ms()->MergeFrom(from.event_timestamp_ms()); 53 to->mutable_event_timestamp_ms()->MergeFrom(from.event_timestamp_ms());
54 if (!to->has_encoded_frame_size()) 54 if (!to->has_encoded_frame_size() && from.has_encoded_frame_size())
55 to->set_encoded_frame_size(from.encoded_frame_size()); 55 to->set_encoded_frame_size(from.encoded_frame_size());
56 if (!to->has_delay_millis()) 56 if (!to->has_delay_millis() && from.has_delay_millis())
57 to->set_delay_millis(from.delay_millis()); 57 to->set_delay_millis(from.delay_millis());
58 if (!to->has_key_frame()) 58 if (!to->has_key_frame() && from.has_key_frame())
59 to->set_key_frame(from.key_frame()); 59 to->set_key_frame(from.key_frame());
60 if (!to->has_target_bitrate() && from.has_target_bitrate())
61 to->set_target_bitrate(from.target_bitrate());
60 } 62 }
61 63
62 bool PopulateDeserializedLog(base::BigEndianReader* reader, 64 bool PopulateDeserializedLog(base::BigEndianReader* reader,
63 media::cast::DeserializedLog* log) { 65 media::cast::DeserializedLog* log) {
64 FrameEventMap frame_event_map; 66 FrameEventMap frame_event_map;
65 PacketEventMap packet_event_map; 67 PacketEventMap packet_event_map;
66 68
67 int num_frame_events = log->metadata.num_frame_events(); 69 int num_frame_events = log->metadata.num_frame_events();
68 RtpTimestamp relative_rtp_timestamp = 0; 70 RtpTimestamp relative_rtp_timestamp = 0;
69 uint16 proto_size = 0; 71 uint16 proto_size = 0;
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 } else { 238 } else {
237 return DoDeserializeEvents(data, data_bytes, audio_log, video_log); 239 return DoDeserializeEvents(data, data_bytes, audio_log, video_log);
238 } 240 }
239 } 241 }
240 242
241 DeserializedLog::DeserializedLog() {} 243 DeserializedLog::DeserializedLog() {}
242 DeserializedLog::~DeserializedLog() {} 244 DeserializedLog::~DeserializedLog() {}
243 245
244 } // namespace cast 246 } // namespace cast
245 } // namespace media 247 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698