Issue 263293003: Cast: Fix a bug with indexing in LogDeserializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263293003: Cast: Fix a bug with indexing in LogDeserializer. (Closed)

Created:
6 years, 7 months ago by imcheng

Modified:
6 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Cast: Fix a bug with indexing in LogDeserializer. The inner loop in MergePacketEvent should be using j to access the BasePacketEvents. Also improved merging logic in MergeFrameEvent a bit. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269522