Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2632863004: Fix MacViewsBrowser build. (Closed)

Created:
3 years, 11 months ago by karandeepb
Modified:
3 years, 11 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, tapted, dtapuska
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MacViewsBrowser build. r443407 changed the WebInputEvent class so that its "type" member variable is accessed via a getter. However, its usage in browser_frame_mac.mm was not updated. This CL changes the code to use the getter, hence fixing the MacViewsBrowser build. BUG=681452 Review-Url: https://codereview.chromium.org/2632863004 Cr-Commit-Position: refs/heads/master@{#444259} Committed: https://chromium.googlesource.com/chromium/src/+/c41a037768a53c4b60be748debba0347a8c10580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/browser_frame_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
karandeepb
PTAL msw@.
3 years, 11 months ago (2017-01-16 06:04:32 UTC) #4
msw
lgtm
3 years, 11 months ago (2017-01-17 18:43:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632863004/1
3 years, 11 months ago (2017-01-18 02:56:30 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 03:33:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c41a037768a53c4b60be748debba...

Powered by Google App Engine
This is Rietveld 408576698