Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2632823002: SPv2: Paint SVG images and self-contained recorded pictures with their own trees. (Closed)

Created:
3 years, 11 months ago by chrishtr
Modified:
3 years, 11 months ago
Reviewers:
pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), fs, gyuyoung2, jbroman, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SPv2: Paint SVG images and self-contained recorded pictures with their own trees. A followup patch will implement flattening the trees into a single display list. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2632823002 Cr-Commit-Position: refs/heads/master@{#444199} Committed: https://chromium.googlesource.com/chromium/src/+/d1f880de459aec1ee63f170addd7fd3e18cf85fd

Patch Set 1 #

Patch Set 2 : none #

Total comments: 3

Messages

Total messages: 17 (12 generated)
chrishtr
3 years, 11 months ago (2017-01-14 00:57:40 UTC) #6
pdr.
LGTM https://codereview.chromium.org/2632823002/diff/20001/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp File third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp (right): https://codereview.chromium.org/2632823002/diff/20001/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp#newcode392 third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp:392: // SVG images paint into their own property ...
3 years, 11 months ago (2017-01-17 21:48:00 UTC) #11
chrishtr
https://codereview.chromium.org/2632823002/diff/20001/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h File third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h (right): https://codereview.chromium.org/2632823002/diff/20001/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h#newcode30 third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h:30: // This node is really a sentinel, and does ...
3 years, 11 months ago (2017-01-17 22:20:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632823002/20001
3 years, 11 months ago (2017-01-17 22:20:59 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 00:19:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d1f880de459aec1ee63f170addd7...

Powered by Google App Engine
This is Rietveld 408576698