add TEAM/COMPONENT information to OWNERS file

add TEAM/COMPONENT information to OWNERS file

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2632813002
Cr-Commit-Position: refs/heads/master@{#445216}
Committed: https://chromium.googlesource.com/chromium/src/+/57c61f9b547f2e65df4ab7131274d43d85549e98

[ymzhang1, 2017-01-14 00:33:32]

Description was changed from

==========
add TEAM/COMPONENT information to OWNERS file

BUG=679905
==========

to

==========
add TEAM/COMPONENT information to OWNERS file

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ymzhang1, 2017-01-14 00:36:15]

ymzhang@chromium.org changed reviewers:
+ dgozman@chromium.org

[ymzhang1, 2017-01-14 00:36:15]

Hello, 

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS file? Thank you very much!

[dgozman, 2017-01-14 01:06:44]

dgozman@chromium.org changed reviewers:
+ jam@chromium.org

[dgozman, 2017-01-14 01:06:45]

[+jam]

Not sure about good mail list for content/OWNERS. John may know better.

https://codereview.chromium.org/2632813002/diff/1/chrome/browser/ui/webui/OWNERS
File chrome/browser/ui/webui/OWNERS (right):

https://codereview.chromium.org/2632813002/diff/1/chrome/browser/ui/webui/OWN...
chrome/browser/ui/webui/OWNERS:32: # COMPONENT: Internals>Network
UI>Browser>WebUI

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS
File content/OWNERS (right):

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS#newcode29
content/OWNERS:29: # TEAM: layout-dev@chromium.org
layout-dev is incorrect here. Not sure about the right one.

[jam, 2017-01-17 23:57:29]

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS
File content/OWNERS (right):

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS#newcode29
content/OWNERS:29: # TEAM: layout-dev@chromium.org
On 2017/01/14 01:06:45, dgozman wrote:
> layout-dev is incorrect here. Not sure about the right one.

What's the intent of the TEAM mailing list here? content/ will be too broad
(i.e. like src/chrome/), so I think it'll be better if you add it in more fine
grained directories underneath.

[ymzhang1, 2017-01-18 00:14:16]

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS
File content/OWNERS (right):

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS#newcode29
content/OWNERS:29: # TEAM: layout-dev@chromium.org
On 2017/01/17 23:57:29, jam wrote:
> On 2017/01/14 01:06:45, dgozman wrote:
> > layout-dev is incorrect here. Not sure about the right one.
> 
> What's the intent of the TEAM mailing list here? content/ will be too broad
> (i.e. like src/chrome/), so I think it'll be better if you add it in more fine
> grained directories underneath.

We would like to add component/team information in every OWNERS when applicable.
The team will be responsible for triage the corresponding component. (related
proposal
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...)

Fine grained directories will add TEAM/COMPONENT information also. If a
directory is too broad and we couldn't find any proper component, we will not
add team/component as suggested.

For content/, maybe it's better to remove both TEAM and COMPONENT information?

[jam, 2017-01-18 17:12:42]

On 2017/01/18 00:14:16, ymzhang1 wrote:
> https://codereview.chromium.org/2632813002/diff/1/content/OWNERS
> File content/OWNERS (right):
> 
> https://codereview.chromium.org/2632813002/diff/1/content/OWNERS#newcode29
> content/OWNERS:29: # TEAM: mailto:layout-dev@chromium.org
> On 2017/01/17 23:57:29, jam wrote:
> > On 2017/01/14 01:06:45, dgozman wrote:
> > > layout-dev is incorrect here. Not sure about the right one.
> > 
> > What's the intent of the TEAM mailing list here? content/ will be too broad
> > (i.e. like src/chrome/), so I think it'll be better if you add it in more
fine
> > grained directories underneath.
> 
> We would like to add component/team information in every OWNERS when
applicable.
> The team will be responsible for triage the corresponding component. (related
> proposal
>
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...)
> 
> Fine grained directories will add TEAM/COMPONENT information also. If a
> directory is too broad and we couldn't find any proper component, we will not
> add team/component as suggested.
> 
> For content/, maybe it's better to remove both TEAM and COMPONENT information?

yeah I think that makes sense

[sshruthi1, 2017-01-18 18:29:45]

On 2017/01/18 17:12:42, jam wrote:
> On 2017/01/18 00:14:16, ymzhang1 wrote:
> > https://codereview.chromium.org/2632813002/diff/1/content/OWNERS
> > File content/OWNERS (right):
> > 
> > https://codereview.chromium.org/2632813002/diff/1/content/OWNERS#newcode29
> > content/OWNERS:29: # TEAM: mailto:layout-dev@chromium.org
> > On 2017/01/17 23:57:29, jam wrote:
> > > On 2017/01/14 01:06:45, dgozman wrote:
> > > > layout-dev is incorrect here. Not sure about the right one.
> > > 
> > > What's the intent of the TEAM mailing list here? content/ will be too
broad
> > > (i.e. like src/chrome/), so I think it'll be better if you add it in more
> fine
> > > grained directories underneath.
> > 
> > We would like to add component/team information in every OWNERS when
> applicable.
> > The team will be responsible for triage the corresponding component.
(related
> > proposal
> >
>
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...)
> > 
> > Fine grained directories will add TEAM/COMPONENT information also. If a
> > directory is too broad and we couldn't find any proper component, we will
not
> > add team/component as suggested.
> > 
> > For content/, maybe it's better to remove both TEAM and COMPONENT
information?
> 
> yeah I think that makes sense

If there is a component/team (even if super high level), I would recommend
adding it here. That way, for any sub-directories that don't have this
information, it could escalate up to this parent directory, if required, if only
to help find the right team/component. So, let us add this information wherever
we have a component/mailing list (however broad).

[ymzhang1, 2017-01-18 19:32:13]

https://codereview.chromium.org/2632813002/diff/1/chrome/browser/ui/webui/OWNERS
File chrome/browser/ui/webui/OWNERS (right):

https://codereview.chromium.org/2632813002/diff/1/chrome/browser/ui/webui/OWN...
chrome/browser/ui/webui/OWNERS:32: # COMPONENT: Internals>Network
On 2017/01/14 01:06:44, dgozman wrote:
> UI>Browser>WebUI

Done.

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS
File content/OWNERS (right):

https://codereview.chromium.org/2632813002/diff/1/content/OWNERS#newcode29
content/OWNERS:29: # TEAM: layout-dev@chromium.org
On 2017/01/18 00:14:16, ymzhang1 wrote:
> On 2017/01/17 23:57:29, jam wrote:
> > On 2017/01/14 01:06:45, dgozman wrote:
> > > layout-dev is incorrect here. Not sure about the right one.
> > 
> > What's the intent of the TEAM mailing list here? content/ will be too broad
> > (i.e. like src/chrome/), so I think it'll be better if you add it in more
fine
> > grained directories underneath.
> 
> We would like to add component/team information in every OWNERS when
applicable.
> The team will be responsible for triage the corresponding component. (related
> proposal
>
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...)
> 
> Fine grained directories will add TEAM/COMPONENT information also. If a
> directory is too broad and we couldn't find any proper component, we will not
> add team/component as suggested.
> 
> For content/, maybe it's better to remove both TEAM and COMPONENT information?

Done.

[jam, 2017-01-20 15:47:49]

On 2017/01/18 18:29:45, sshruthi1 wrote:
> On 2017/01/18 17:12:42, jam wrote:
> > On 2017/01/18 00:14:16, ymzhang1 wrote:
> > > https://codereview.chromium.org/2632813002/diff/1/content/OWNERS
> > > File content/OWNERS (right):
> > > 
> > > https://codereview.chromium.org/2632813002/diff/1/content/OWNERS#newcode29
> > > content/OWNERS:29: # TEAM: mailto:layout-dev@chromium.org
> > > On 2017/01/17 23:57:29, jam wrote:
> > > > On 2017/01/14 01:06:45, dgozman wrote:
> > > > > layout-dev is incorrect here. Not sure about the right one.
> > > > 
> > > > What's the intent of the TEAM mailing list here? content/ will be too
> broad
> > > > (i.e. like src/chrome/), so I think it'll be better if you add it in
more
> > fine
> > > > grained directories underneath.
> > > 
> > > We would like to add component/team information in every OWNERS when
> > applicable.
> > > The team will be responsible for triage the corresponding component.
> (related
> > > proposal
> > >
> >
>
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...)
> > > 
> > > Fine grained directories will add TEAM/COMPONENT information also. If a
> > > directory is too broad and we couldn't find any proper component, we will
> not
> > > add team/component as suggested.
> > > 
> > > For content/, maybe it's better to remove both TEAM and COMPONENT
> information?
> > 
> > yeah I think that makes sense
> 
> If there is a component/team (even if super high level), I would recommend
> adding it here. That way, for any sub-directories that don't have this
> information, it could escalate up to this parent directory, if required, if
only
> to help find the right team/component. So, let us add this information
wherever
> we have a component/mailing list (however broad).

You can use COMPONENT: Internals>Core, but there's no TEAM.

[ymzhang1, 2017-01-20 17:23:50]

add Internals>Core in content/OWNERS, but no team.

[jam, 2017-01-20 22:22:12]

lgtm

[ymzhang1, 2017-01-20 22:52:51]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:53:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 23:58:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484952771078180,
"parent_rev": "d031eed215c8eb25b38458297ffe7175661dd3f4", "commit_rev":
"57c61f9b547f2e65df4ab7131274d43d85549e98"}

[commit-bot: I haz the power, 2017-01-20 23:58:51]

Description was changed from

==========
add TEAM/COMPONENT information to OWNERS file

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
add TEAM/COMPONENT information to OWNERS file

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2632813002
Cr-Commit-Position: refs/heads/master@{#445216}
Committed:
https://chromium.googlesource.com/chromium/src/+/57c61f9b547f2e65df4ab7131274...
==========

[commit-bot: I haz the power, 2017-01-20 23:58:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/57c61f9b547f2e65df4ab7131274...