Index: base/debug/stack_trace.h |
diff --git a/base/debug/stack_trace.h b/base/debug/stack_trace.h |
index d4918d60654b808719ebcfdda6be74d43174f75d..1c288398ffa7ab069fa1b449f91ee502be84c4d0 100644 |
--- a/base/debug/stack_trace.h |
+++ b/base/debug/stack_trace.h |
@@ -53,6 +53,10 @@ class BASE_EXPORT StackTrace { |
// Creates a stacktrace from the current location. |
StackTrace(); |
+ // Creates a stacktrace from the current location, of up to |count| entries. |
+ // |count| will be trimmed to |kMaxTraces|. |
dcheng
2017/01/28 01:00:33
Nit: to me, trimmed isn't an operation that applie
Wez
2017/01/29 04:25:01
Agreed; I just copied the wording from the constru
|
+ explicit StackTrace(size_t count); |
+ |
// Creates a stacktrace from an existing array of instruction |
// pointers (such as returned by Addresses()). |count| will be |
// trimmed to |kMaxTraces|. |
@@ -68,8 +72,6 @@ class BASE_EXPORT StackTrace { |
// Copying and assignment are allowed with the default functions. |
- ~StackTrace(); |
- |
// Gets an array of instruction pointer values. |*count| will be set to the |
// number of elements in the returned array. |
const void* const* Addresses(size_t* count) const; |
@@ -90,6 +92,7 @@ class BASE_EXPORT StackTrace { |
void InitTrace(const _CONTEXT* context_record); |
#endif |
+ protected: |
dcheng
2017/01/28 01:00:33
Why protected?
Wez
2017/01/29 04:25:01
Oh, strange; no idea where that came from :-/
|
// From http://msdn.microsoft.com/en-us/library/bb204633.aspx, |
// the sum of FramesToSkip and FramesToCapture must be less than 63, |
// so set it to 62. Even if on POSIX it could be a larger value, it usually |