Remove WTFReportAssertionFailure and WTFReportBacktrace.

base/debug/stack_trace.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_DEBUG_STACK_TRACE_H_
 #define BASE_DEBUG_STACK_TRACE_H_
 
 #include <stddef.h>
 
 #include <iosfwd>
@@ skipping 35 matching lines @@
 BASE_EXPORT bool EnableInProcessStackDumping();
 
 // A stacktrace can be helpful in debugging. For example, you can include a
 // stacktrace member in a object (probably around #ifndef NDEBUG) so that you
 // can later see where the given object was created from.
 class BASE_EXPORT StackTrace {
  public:
   // Creates a stacktrace from the current location.
   StackTrace();
 
+  // Creates a stacktrace from the current location, of up to |count| entries.
+  // |count| will be trimmed to |kMaxTraces|.

[dcheng, 2017/01/28 01:00:33]

Nit: to me, trimmed isn't an operation that applies to integers. I suggest
limited or clamped.

[Wez, 2017/01/29 04:25:01]

Agreed; I just copied the wording from the constructor below, for consistency.
Have updated the wording to "limited at most to".

+  explicit StackTrace(size_t count);
+
   // Creates a stacktrace from an existing array of instruction
   // pointers (such as returned by Addresses()).  |count| will be
   // trimmed to |kMaxTraces|.
   StackTrace(const void* const* trace, size_t count);
 
 #if defined(OS_WIN)
   // Creates a stacktrace for an exception.
   // Note: this function will throw an import not found (StackWalk64) exception
   // on system without dbghelp 5.1.
   StackTrace(_EXCEPTION_POINTERS* exception_pointers);
   StackTrace(const _CONTEXT* context);
 #endif
 
   // Copying and assignment are allowed with the default functions.
 
-  ~StackTrace();
-
   // Gets an array of instruction pointer values. |*count| will be set to the
   // number of elements in the returned array.
   const void* const* Addresses(size_t* count) const;
 
   // Prints the stack trace to stderr.
   void Print() const;
 
 #if !defined(__UCLIBC__)
   // Resolves backtrace to symbols and write to stream.
   void OutputToStream(std::ostream* os) const;
 #endif
 
   // Resolves backtrace to symbols and returns as string.
   std::string ToString() const;
 
  private:
 #if defined(OS_WIN)
   void InitTrace(const _CONTEXT* context_record);
 #endif
 
+ protected:

[dcheng, 2017/01/28 01:00:33]

Why protected?

[Wez, 2017/01/29 04:25:01]

Oh, strange; no idea where that came from :-/

   // From http://msdn.microsoft.com/en-us/library/bb204633.aspx,
   // the sum of FramesToSkip and FramesToCapture must be less than 63,
   // so set it to 62. Even if on POSIX it could be a larger value, it usually
   // doesn't give much more information.
   static const int kMaxTraces = 62;
 
   void* trace_[kMaxTraces];
 
   // The number of valid frames in |trace_|.
   size_t count_;
@@ skipping 79 matching lines @@
                          int base,
                          size_t padding);
 #endif  // defined(OS_POSIX) && !defined(OS_ANDROID)
 
 }  // namespace internal
 
 }  // namespace debug
 }  // namespace base
 
 #endif  // BASE_DEBUG_STACK_TRACE_H_